From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 13 Sep 2012 11:35:08 +0200
Subject: [U-Boot] [PATCH 4/4 v3] xilinx: Add new Zynq board
In-Reply-To: <1345098630-27902-4-git-send-email-monstr@monstr.eu>
References: <1345098630-27902-1-git-send-email-monstr@monstr.eu>
	<1345098630-27902-4-git-send-email-monstr@monstr.eu>
Message-ID: <201209131135.08970.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Michal Simek,

[...]

> +int board_init(void)
> +{
> +	icache_enable();

Uh oh ... isn't this on by default when CONFIG_ICACHE_OFF isn't present?

> +	return 0;
> +}
> +
> +int board_late_init(void)
> +{
> +	return 0;

You don't need this.

> +}
> +
> +#ifdef CONFIG_CMD_NET
> +int board_eth_init(bd_t *bis)
> +{
> +	int ret = 0;
> +
> +#if defined(CONFIG_ZYNQ_GEM) && defined(CONFIG_ZYNQ_GEM_BASEADDR0)
> +	ret |= zynq_gem_initialize(bis, CONFIG_ZYNQ_GEM_BASEADDR0);

ret |= ? ;-)

> +#endif
> +
> +	return ret;
> +}
> +#endif
> +
> +int dram_init(void)
> +{
> +	gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
> +	return 0;
> +}
> +
> +void reset_cpu(ulong addr)
> +{
> +	while (1)
> +		;
> +}

This is definitelly CPU specific.
[...]