From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 14 Sep 2012 01:38:57 +0200 Subject: [U-Boot] [PATCH 7/9] Tegra30: Add config files (common and Cardhu) In-Reply-To: <505261FA.3070909@ti.com> References: <1347487855-27077-1-git-send-email-twarren@nvidia.com> <50525F22.20807@wwwdotorg.org> <505261FA.3070909@ti.com> Message-ID: <201209140138.57317.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Tom Rini, > On 09/13/2012 03:33 PM, Stephen Warren wrote: > > On 09/12/2012 04:10 PM, Tom Warren wrote: > >> diff --git a/include/configs/tegra30-common.h > >> b/include/configs/tegra30-common.h > >> > >> +/* > >> + * QUOTE(m) will evaluate to a string version of the value of the macro > >> m + * passed in. The extra level of indirection here is to first > >> evaluate the + * macro m before applying the quoting operator. > >> + */ > >> +#define QUOTE_(m) #m > >> +#define QUOTE(m) QUOTE_(m) > > > > Seems like a good candidate for a common header (not Tegra-common, but > > across all of U-Boot). > > This is __stringify() that Marek needs to address Wolfgang's comment on > still, iirc. I need to roll out the stringify patches ... the issues should be fixed. > >> +#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600,\ > >> + 115200} > > > > IIRC, that's the default now and can be removed. There may be other > > variables the comment applies to - Tom Rini would know better since he > > pointed them out in my RPi patches. > > That and the hush prompt one if it's there need to go. Best regards, Marek Vasut