From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4 v2] serial: Add Zynq serial driver
Date: Fri, 14 Sep 2012 06:47:57 +0200 [thread overview]
Message-ID: <201209140647.57886.marex@denx.de> (raw)
In-Reply-To: <CANr=Z=bLwrHnYYK_NqfFpOspua--VTXq3bQ5rUVXAcRFgXtaaw@mail.gmail.com>
Dear Joe Hershberger,
> Hi Marek,
>
> On Thu, Sep 13, 2012 at 9:01 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Michal Simek,
> >
> >> On 09/13/2012 02:33 PM, Marek Vasut wrote:
> >> > Dear Michal Simek,
> >> >
> >> >> On 09/13/2012 11:21 AM, Marek Vasut wrote:
> >> >>> Dear Michal Simek,
> >> >>>
> >> >>>> The driver is used on Xilinx Zynq platform.
> >> >>>>
> >> >>>> Signed-off-by: Michal Simek <monstr@monstr.eu>
> >> >>>>
> >> >>>> ---
> >> >>>> v2: Use Zynq name instead of Dragonfire and XPSS/XDFUART
> >> >>>>
> >> >>>> Rename driver name
> >> >>>> Remove driver description
> >> >>>>
> >> >>>> ---
> >> >>>>
> >> >>>> drivers/serial/Makefile | 1 +
> >> >>>> drivers/serial/serial_zynq.c | 200
> >> >>>>
> >> >>>> ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 201
> >> >>>> insertions(+), 0 deletions(-)
> >> >>>>
> >> >>>> create mode 100644 drivers/serial/serial_zynq.c
> >> >>>
> >> >>> [...]
> >> >>>
> >> >>> It looks ok, but can you make it support CONFIG_SERIAL_MULTI right
> >> >>> away please?
> >> >>
> >> >> Yes, it will add serial_multi in the next patch.
> >> >> Can you give me your ACK or reviewed-by line? :-)
> >> >
> >> > Just squash them into one patch please.
> >>
> >> Done.
> >
> > Thanks ... my idea is to switch to serial_multi completely, then rework
> > stdio, unify serial on top of it and clean up the whole subsystem.
> > Thanks for helping!
>
> I have a patch that I'll send soon that moves the "nulldev" driver to
> the serial driver (if CONFIG_SERIAL_MULTI is defined) so that it is
> possible to avoid serial init.
Thanks, this will break my massive patchset though. Can you check
git://git.denx.de/u-boot-marex.git / stdio branch ? I did something to nulldev
there. Probably ignore the top 7 patches, they're bogus and need further work.
It's all still work in progress to some point.
> I had the problem that the serial port
> on my Zynq product lives in the fabric instead of using the hard-core
> ones.
I see ... why don't you implement nulldev_serial instead and leave nulldev stdio
as is?
> This means that the FPGA neds to be configured first, but since
> I'm using u-boot for that too, I need it to start as null and switch
> to the fabric serial after the FPGA is configured. Anyway, just more
> support for supporting CONFIG_SERIAL_MULTI.
>
> -Joe
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-14 4:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 6:30 [U-Boot] [PATCH 1/4 v2] serial: Add Zynq serial driver Michal Simek
2012-08-16 6:30 ` [U-Boot] [PATCH 2/4 v2] net: Add driver for Zynq Gem IP Michal Simek
2012-09-12 10:19 ` Michal Simek
2012-09-13 9:28 ` Marek Vasut
2012-09-13 10:16 ` Michal Simek
2012-09-13 12:30 ` Marek Vasut
2012-09-14 3:49 ` Joe Hershberger
2012-09-14 4:45 ` Marek Vasut
[not found] ` <CANr=Z=aejhXoGabpcderroSeQSWJM+cbXS7yg6NVeHKJLqQhRQ@mail.gmail.com>
2012-09-14 7:34 ` Marek Vasut
2012-08-16 6:30 ` [U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform Michal Simek
2012-09-12 10:23 ` Michal Simek
2012-09-13 9:32 ` Marek Vasut
2012-09-13 9:36 ` Michal Simek
2012-09-13 9:31 ` Marek Vasut
2012-09-13 9:52 ` Michal Simek
2012-09-13 10:31 ` Marek Vasut
2012-09-13 11:24 ` Michal Simek
2012-09-13 12:32 ` Marek Vasut
2012-09-13 12:52 ` Michal Simek
2012-09-13 13:01 ` Marek Vasut
2012-08-16 6:30 ` [U-Boot] [PATCH 4/4 v3] xilinx: Add new Zynq board Michal Simek
2012-09-12 10:23 ` Michal Simek
2012-09-13 9:35 ` Marek Vasut
2012-09-13 9:55 ` Michal Simek
2012-09-13 12:31 ` Marek Vasut
2012-09-13 12:17 ` Michal Simek
2012-09-14 4:03 ` Joe Hershberger
2012-09-14 5:42 ` Michal Simek
2012-09-12 10:20 ` [U-Boot] [PATCH 1/4 v2] serial: Add Zynq serial driver Michal Simek
2012-09-13 9:21 ` Marek Vasut
2012-09-13 9:45 ` Michal Simek
2012-09-13 12:33 ` Marek Vasut
2012-09-13 13:54 ` Michal Simek
2012-09-13 14:01 ` Marek Vasut
2012-09-14 4:09 ` Joe Hershberger
2012-09-14 4:47 ` Marek Vasut [this message]
2012-09-14 5:23 ` Joe Hershberger
2012-09-14 7:39 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209140647.57886.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox