From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 14 Sep 2012 12:17:36 +0200 Subject: [U-Boot] [PATCH 1/3] dm: sparc: net: Fixup greth compile warnings In-Reply-To: <1343412274-21500-1-git-send-email-marex@denx.de> References: <1343412274-21500-1-git-send-email-marex@denx.de> Message-ID: <201209141217.36777.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, can you pick these three sparc things by hand please? > greth.c: In function ?greth_recv?: > greth.c:507:3: warning: format ?%lx? expects argument of type ?long > unsigned int?, but argument 2 has type ?unsigned int? [-Wformat] > greth.c:507:3: warning: format ?%lx? expects argument of type ?long > unsigned int?, but argument 3 has type ?unsigned int? [-Wformat] > greth.c:541:6: warning: pointer targets in assignment differ in signedness > [-Wpointer-sign] greth.c: In function ?greth_initialize?: > greth.c:623:2: warning: format ?%lx? expects argument of type ?long > unsigned int?, but argument 2 has type ?struct greth_regs *? [-Wformat] > greth.c:655:3: warning: format ?%x? expects argument of type ?unsigned > int?, but argument 2 has type ?struct greth_regs *? [-Wformat] > greth.c:684:2: warning: format ?%x? expects argument of type ?unsigned > int?, but argument 2 has type ?struct greth_regs *? [-Wformat] > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Daniel Hellstrom > Cc: u-boot-dm at lists.denx.de > --- > drivers/net/greth.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/greth.c b/drivers/net/greth.c > index 08206c8..3103a74 100644 > --- a/drivers/net/greth.c > +++ b/drivers/net/greth.c > @@ -483,7 +483,7 @@ int greth_recv(struct eth_device *dev) > greth_regs *regs = greth->regs; > greth_bd *rxbd; > unsigned int status, len = 0, bad; > - unsigned char *d; > + char *d; > int enable = 0; > int i; > > @@ -504,7 +504,7 @@ int greth_recv(struct eth_device *dev) > goto done; > } > > - debug("greth_recv: packet 0x%lx, 0x%lx, len: %d\n", > + debug("greth_recv: packet 0x%x, 0x%x, len: %d\n", > (unsigned int)rxbd, status, status & GRETH_BD_LEN); > > /* Check status for errors. > @@ -620,7 +620,7 @@ int greth_initialize(bd_t * bis) > > greth->regs = (greth_regs *) apbdev.address; > greth->irq = apbdev.irq; > - debug("Found GRETH at 0x%lx, irq %d\n", greth->regs, greth->irq); > + debug("Found GRETH at %p, irq %d\n", greth->regs, greth->irq); > dev->priv = (void *)greth; > dev->iobase = (unsigned int)greth->regs; > dev->init = greth_init; > @@ -652,7 +652,7 @@ int greth_initialize(bd_t * bis) > /* initiate PHY, select speed/duplex depending on connected PHY */ > if (greth_init_phy(greth, bis)) { > /* Failed to init PHY (timedout) */ > - debug("GRETH[0x%08x]: Failed to init PHY\n", greth->regs); > + debug("GRETH[%p]: Failed to init PHY\n", greth->regs); > return -1; > } > > @@ -681,6 +681,6 @@ int greth_initialize(bd_t * bis) > /* set and remember MAC address */ > greth_set_hwaddr(greth, addr); > > - debug("GRETH[0x%08x]: Initialized successfully\n", greth->regs); > + debug("GRETH[%p]: Initialized successfully\n", greth->regs); > return 0; > } Best regards, Marek Vasut