From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv3] ARM: Add Altera SOCFPGA Cyclone5
Date: Fri, 14 Sep 2012 10:12:22 -0700 [thread overview]
Message-ID: <20120914171222.GA22028@bill-the-cat> (raw)
In-Reply-To: <1347642157-1829-1-git-send-email-dinguyen@altera.com>
On Fri, Sep 14, 2012 at 11:02:37AM -0600, dinguyen at altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> Add minimal support for Altera's SOCFPGA Cyclone 5 hardware.
[snip]
> +/*
> + * Write the reset manager register to cause reset
> + */
> +__attribute__((noreturn)) void reset_cpu(ulong addr)
Please add <linux/compiler.h> to the file and use __noreturn, thanks
(but when adding the prototype to include/common.h spell it out like
this, this is a known issue atm, we can't use <linux/compiler.h> in
<common.h> right now).
> diff --git a/arch/arm/include/asm/arch-kirkwood/cpu.h b/arch/arm/include/asm/arch-kirkwood/cpu.h
> index d28c51a..7a53c8f 100644
> --- a/arch/arm/include/asm/arch-kirkwood/cpu.h
> +++ b/arch/arm/include/asm/arch-kirkwood/cpu.h
> @@ -155,7 +155,6 @@ struct kwgpio_registers {
> /*
> * functions
> */
> -void reset_cpu(unsigned long ignored);
> unsigned char get_random_hex(void);
> unsigned int kw_sdram_bar(enum memory_bank bank);
> unsigned int kw_sdram_bs(enum memory_bank bank);
> diff --git a/arch/arm/include/asm/arch-orion5x/cpu.h b/arch/arm/include/asm/arch-orion5x/cpu.h
> index 2f52ca8..17b9b69 100644
> --- a/arch/arm/include/asm/arch-orion5x/cpu.h
> +++ b/arch/arm/include/asm/arch-orion5x/cpu.h
> @@ -251,7 +251,6 @@ struct orion5x_ddr_addr_decode_registers {
> /*
> * functions
> */
> -void reset_cpu(unsigned long ignored);
> u32 orion5x_device_id(void);
> u32 orion5x_device_rev(void);
> unsigned int orion5x_winctrl_calcsize(unsigned int sizeval);
The reset_cpu bugfix (which I am glad you're doing) needs to be a
separate patch. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120914/755067cd/attachment.pgp>
prev parent reply other threads:[~2012-09-14 17:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 17:02 [U-Boot] [PATCHv3] ARM: Add Altera SOCFPGA Cyclone5 dinguyen at altera.com
2012-09-14 17:02 ` Marek Vasut
2012-09-14 20:54 ` Dinh Nguyen
2012-09-14 17:12 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914171222.GA22028@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox