From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/7] dm: Add skeleton support for cores and drivers
Date: Fri, 14 Sep 2012 11:29:49 -0700 [thread overview]
Message-ID: <20120914182949.GG22028@bill-the-cat> (raw)
In-Reply-To: <1345564853-24500-2-git-send-email-marex@denx.de>
On Tue, Aug 21, 2012 at 06:00:47PM +0200, Marek Vasut wrote:
> From: Pavel Herrmann <morpheus.ibis@gmail.com>
>
> Signed-off-by: Pavel Herrmann <morpheus.ibis@gmail.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
More of a commit message please. At least point to the design docs that
are now in tree.
> +#ifndef _COMMON_DM_TREE_H_
> +#define _COMMON_DM_TREE_H_ 1
#ifndef __COMMON_DM_TREE_H
#define __COMMON_DM_TREE_H
etc, etc. You also pass in 'i' as a variable to one of the functions at
least. Please make sure you use real variable names in functions.
--
Tom
next prev parent reply other threads:[~2012-09-14 18:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 16:00 [U-Boot] [PATCH 0/7] [RFC] Driver model, take 1 Marek Vasut
2012-08-21 16:00 ` [U-Boot] [PATCH 1/7] dm: Add skeleton support for cores and drivers Marek Vasut
2012-09-14 18:29 ` Tom Rini [this message]
2012-08-21 16:00 ` [U-Boot] [PATCH 2/7] dm: sandbox: Add necessary linker sections Marek Vasut
2012-08-21 16:00 ` [U-Boot] [PATCH 3/7] dm: sandbox: Add necessary GD sections Marek Vasut
2012-08-21 16:00 ` [U-Boot] [PATCH 4/7] dm: REMOVE: sandbox binding experiment Marek Vasut
2012-08-21 16:00 ` [U-Boot] [PATCH 5/7] dm: gpio: Add draft GPIO core and convert sandbox to use it Marek Vasut
2012-08-29 12:00 ` Pavel Herrmann
2012-08-21 16:00 ` [U-Boot] [PATCH 6/7] dm: add dummy demo driver and core Marek Vasut
2012-08-21 16:00 ` [U-Boot] [PATCH 7/7] dm: Add "dm dump" command Marek Vasut
2012-08-22 18:28 ` [U-Boot] [PATCH 0/7] [RFC] Driver model, take 1 Marek Vasut
2012-09-04 1:06 ` Graeme Russ
2012-09-04 6:44 ` Marek Vasut
2012-09-04 6:48 ` Graeme Russ
2012-09-14 18:34 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914182949.GG22028@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox