public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 08/11] rtc: Don't allow setting unsuported years on s3c24x0_rtc
Date: Fri, 14 Sep 2012 20:08:46 +0200	[thread overview]
Message-ID: <201209142008.46842.marex@denx.de> (raw)
In-Reply-To: <1347643742-19966-9-git-send-email-jose.goncalves@inov.pt>

Dear Jos? Miguel Gon?alves,

> This RTC only supports a 100 years range so rtc_set() should not allow
> setting years bellow 1970 or above 2069.

Acked-by: Marek Vasut <marex@denx.de>

> Signed-off-by: Jos? Miguel Gon?alves <jose.goncalves@inov.pt>
> ---
> Changes for v2:
>    - New patch
> ---
>  drivers/rtc/s3c24x0_rtc.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/rtc/s3c24x0_rtc.c b/drivers/rtc/s3c24x0_rtc.c
> index 54bf6e3..f96cb11 100644
> --- a/drivers/rtc/s3c24x0_rtc.c
> +++ b/drivers/rtc/s3c24x0_rtc.c
> @@ -139,6 +139,11 @@ int rtc_set(struct rtc_time *tmp)
>  	       tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
>  	       tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
>  #endif
> +	if (tmp->tm_year < 1970 || tmp->tm_year > 2069) {
> +		puts("ERROR: year should be between 1970 and 2069!\n");
> +		return -1;
> +	}
> +
>  	year = bin2bcd(tmp->tm_year % 100);
>  	mon  = bin2bcd(tmp->tm_mon);
>  	wday = bin2bcd(tmp->tm_wday);

Best regards,
Marek Vasut

  reply	other threads:[~2012-09-14 18:08 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14 17:28 [U-Boot] [PATCH v2 00/11] S3C24XX: Add support to MINI2416 board José Miguel Gonçalves
2012-09-14 17:28 ` [U-Boot] [PATCH v2 01/11] ARM: fix relocation on ARM926EJS José Miguel Gonçalves
2012-09-15 18:03   ` Marek Vasut
2012-09-16  9:45     ` José Miguel Gonçalves
2012-09-16 10:06       ` Marek Vasut
2012-09-16 10:16         ` José Miguel Gonçalves
2012-09-16 15:36           ` Marek Vasut
2012-09-16 16:26             ` José Miguel Gonçalves
2012-09-16 17:17               ` Marek Vasut
2012-09-17  6:28             ` Christian Riesch
2012-09-17  8:34               ` José Miguel Gonçalves
2012-09-17  9:03                 ` Christian Riesch
2012-09-17  9:20                   ` José Miguel Gonçalves
2012-09-17 17:18             ` Tom Rini
2012-09-17 17:23               ` Scott Wood
2012-09-17 17:32                 ` Tom Rini
2012-09-17 17:26               ` Marek Vasut
2012-09-17 17:35                 ` Tom Rini
2012-09-17 17:48                   ` Marek Vasut
2012-09-17 18:00                     ` Tom Rini
2012-09-17 17:27               ` José Miguel Gonçalves
2012-10-04 14:24   ` Albert ARIBAUD
2012-09-14 17:28 ` [U-Boot] [PATCH v2 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs José Miguel Gonçalves
2012-09-14 18:03   ` Marek Vasut
     [not found]     ` <505375E3.6050005@inov.pt>
2012-09-14 18:25       ` Marek Vasut
2012-09-14 19:01         ` Scott Wood
2012-09-14 19:07           ` Marek Vasut
2012-09-14 19:17             ` Scott Wood
2012-09-14 18:39   ` Tom Rini
2012-09-14 17:28 ` [U-Boot] [PATCH v2 03/11] serial: Add support to 4 ports in serial_s3c24x0 José Miguel Gonçalves
2012-09-14 17:28 ` [U-Boot] [PATCH v2 04/11] serial: Use a more precise baud rate generation for serial_s3c24x0 José Miguel Gonçalves
2012-09-14 18:05   ` Marek Vasut
2012-09-14 17:28 ` [U-Boot] [PATCH v2 05/11] serial: Remove unnecessary delay in serial_s3c24x0 José Miguel Gonçalves
2012-09-14 18:05   ` Marek Vasut
2012-09-14 17:28 ` [U-Boot] [PATCH v2 06/11] rtc: Improve rtc_get() on s3c24x0_rtc José Miguel Gonçalves
2012-09-14 18:06   ` Marek Vasut
2012-09-14 17:28 ` [U-Boot] [PATCH v2 07/11] rtc: Fix rtc_reset() " José Miguel Gonçalves
2012-09-14 18:07   ` Marek Vasut
2012-09-14 17:28 ` [U-Boot] [PATCH v2 08/11] rtc: Don't allow setting unsuported years " José Miguel Gonçalves
2012-09-14 18:08   ` Marek Vasut [this message]
2012-09-14 17:29 ` [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver José Miguel Gonçalves
2012-09-14 18:21   ` Marek Vasut
2012-09-14 18:45     ` José Miguel Gonçalves
2012-09-14 19:01       ` Tom Rini
2012-09-16  9:16         ` José Miguel Gonçalves
2012-09-17 16:57           ` Tom Rini
2012-09-17 17:03             ` Scott Wood
2012-09-17 17:08               ` Tom Rini
2012-09-17 17:13                 ` Scott Wood
2012-09-17 17:08             ` José Miguel Gonçalves
2012-09-17 17:56               ` Tom Rini
2012-09-17 18:05                 ` José Miguel Gonçalves
2012-09-17 18:27                   ` Tom Rini
2012-09-17 18:34                     ` José Miguel Gonçalves
2012-09-17 18:56                       ` Tom Rini
2012-09-14 19:24     ` Scott Wood
2012-09-14 20:20       ` Tom Rini
2012-09-14 20:29         ` Scott Wood
2012-09-17 11:11     ` José Miguel Gonçalves
2012-09-14 18:47   ` Tom Rini
2012-09-14 17:29 ` [U-Boot] [PATCH v2 10/11] Add u-boot-ubl.bin target to the Makefile José Miguel Gonçalves
2012-09-14 18:22   ` Marek Vasut
2012-09-14 19:08   ` Tom Rini
2012-09-16  9:27     ` José Miguel Gonçalves
2012-09-17  6:47       ` Christian Riesch
2012-09-17  8:30         ` José Miguel Gonçalves
2012-09-17  9:10           ` Christian Riesch
2012-09-17  9:24             ` José Miguel Gonçalves
2012-09-17 14:45               ` Tom Rini
2012-09-17 16:29                 ` Marek Vasut
2012-09-17 16:35                   ` Tom Rini
2012-09-17 16:27               ` Scott Wood
2012-09-17 16:51                 ` Tom Rini
2012-09-17 17:32                   ` Scott Wood
2012-09-17 17:53                     ` Tom Rini
2012-09-17 18:16                       ` Scott Wood
2012-09-17 19:52                       ` Wolfgang Denk
2012-09-14 17:29 ` [U-Boot] [PATCH v2 11/11] S3C24XX: Add support to MINI2416 board José Miguel Gonçalves
2012-09-14 18:58   ` Tom Rini
2012-09-16  9:11     ` José Miguel Gonçalves
2012-09-17 14:39       ` Tom Rini
2012-09-17 14:47         ` José Miguel Gonçalves
2012-09-17 15:11           ` Tom Rini
2012-09-18 12:11             ` José Miguel Gonçalves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209142008.46842.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox