From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 14 Sep 2012 21:07:12 +0200
Subject: [U-Boot] [PATCH v2 02/11] S3C24XX: Add core support for
	Samsung's S3C24XX SoCs
In-Reply-To: <20120914190124.GA5157@buserror.net>
References: <1347643742-19966-1-git-send-email-jose.goncalves@inov.pt>
	<201209142025.25953.marex@denx.de>
	<20120914190124.GA5157@buserror.net>
Message-ID: <201209142107.12148.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Scott Wood,

> On Fri, Sep 14, 2012 at 08:25:25PM +0200, Marek Vasut wrote:
> > Dear Jos? Miguel Gon?alves,
> > 
> > > Hi Marek,
> > > 
> > > On 14-09-2012 19:03, Marek Vasut wrote:
> > > > Dear Jos? Miguel Gon?alves,
> > > > 
> > > > It's getting better :)
> > > 
> > > Hopefully :-)
> > > 
> > > > [...]
> > > > 
> > > >> +
> > > >> +typedef ulong(*getfreq) (void);
> > > > 
> > > > Is this used?
> > > 
> > > In the array declaration bellow...
> > 
> > Why, these are only values, no ?
> 
> They're function pointers.  If they were values the compiler should
> complain, because "getfreq" is used as the type of the array.
> 
> > > >> +static const getfreq freq_f[] = {
> > > > 
> > > > const array const members, no?
> > > 
> > > Do you mean I should declare it like this:
> > > 
> > > static const getfreq const freq[] = { ...
> > 
> > Yes
> 
> Why?  When can you ever change what an array (not a pointer) points to?

Uh oh ... now I see the stuff with the functions. Crazy

> > > I don't see the point because an array has no other storage besides
> > > it's elements. Moreover GCC generates the same object code in both
> > > ways.
> > 
> > Type checking, if you ever decided to write into the array, it'll prevent
> > you from doing so.
> 
> The first const takes care of that.

Doesn't one prevent you from manupulating the elements and the other 
manipulating the array ?

> -Scott

Best regards,
Marek Vasut