[U-Boot] [PATCH 09/16] pmic:fuel-gauge: Support for MAX17042 fuel-gauge

Lukasz Majewski
2012-09-17T20:59:43Z

Hi Tom ,

> On Fri, Sep 14, 2012 at 05:40:08PM +0200, Lukasz Majewski wrote:
>
> > Support for MAX17042 fuel-gauge (FG), which is built into the
> > MAX8997 power management device.
> > Special file - fg_battery_cell_params.h with cells characteristics
> > added.
> [snip]
> > +#ifndef __FG_BATTERY_CELL_PARAMS_H_
> > +#define __FG_BATTERY_CELL_PARAMS_H_
> > +
> > +#if defined(CONFIG_POWER_FG_MAX17042) && defined(CONFIG_TRATS)
> > +
> > +/* Cell characteristics - Exynos4 TRATS development board */
> > +
> > +u16 cell_character0[16] /* Shall be written to addr 0x80h */
> > += { 0xA2A0,
>
> This (and the rest of the file) should be:
> /* Shall be written to addr 0x80h */
> u16 cell_character0[16] = {
> 0xA2A0,
> ...
>

Ok, I will fix this.
> Thanks.
>
> Also:
> [snip]
> > + MAX17042_AVG_CURRENT = 0x0B,
> > + MAX17042_SOCMIX = 0x0D,
> > + MAX17042_SOCAV = 0x0E,
>
> I assume this is just odd formatting in the mail and once applied it's
> aligned. If not, please fix (and check the rest of the series).
> Thanks!
>

I will double check that. Nether checkpatch nor emac's
whitespace-cleanup weren't complaining.

Regards,
Lukasz