From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukasz Majewski <lukma633@gmail.com>
Date: Mon, 17 Sep 2012 22:55:22 +0200
Subject: [U-Boot] [PATCH 15/16] arm:trats:pmic: Support for charging
 battery at Samsung's TRATS board
In-Reply-To: <20120914173213.GE22028@bill-the-cat>
References: <1347637215-4830-1-git-send-email-l.majewski@samsung.com>
	<1347637215-4830-16-git-send-email-l.majewski@samsung.com>
	<20120914173213.GE22028@bill-the-cat>
Message-ID: <20120917225522.1d98f0c7@jawa>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tom ,

> If I read this right we'll pause in the middle of start up to charge
> the battery for possibly a long time right?  And this could be a
> while loop even, yes?  If so to the first one, this really should be
> under some sort of CONFIG option.

This is one of the options. Other option is to extend the pmic/power
command to:

pmic charger on/off to recharge battery when needed.

I think, that above is a better solution.

> I know the value of showing proof of concept
> type examples in development boards but that should still be an opt-in
> thing I would think.

Yes, indeed this shall be regarded as a proof-of-concept to show that
battery is automatically charged when needed.

Instead, I think, that it would be a good idea to write a warning on
the u-boot starting (when PMIC driver is initialized):

e.g. WARNING: Battery needs charging (voltage: 3.5V capacity: 8%)

And then user can on its own decide if he/she will charge the battery or
not.

Regards,
Lukasz Majewski