From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 17 Sep 2012 19:36:28 -0500 Subject: [U-Boot] [PATCH v2 13/13] mxc nand: Add support for i.MX5 In-Reply-To: <684093264.2662811.1345583054386.JavaMail.root@advansee.com> References: <1297105590.2375011.1344891064392.JavaMail.root@advansee.com> <684093264.2662811.1345583054386.JavaMail.root@advansee.com> Message-ID: <20120918003628.GA31969@buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Aug 21, 2012 at 11:04:14PM +0200, Beno?t Th?baudeau wrote: > Signed-off-by: Beno?t Th?baudeau > Cc: Scott Wood > Cc: Stefano Babic > --- > Changes for v2: > - Fix warning for unused tmp variable in board_nand_init() for NFC V1. > > .../arch/arm/include/asm/arch-mx5/imx-regs.h | 9 + > .../drivers/mtd/nand/mxc_nand.c | 219 +++++++++++++++----- > .../include/fsl_nfc.h | 149 ++++++++----- > .../nand_spl/nand_boot_fsl_nfc.c | 114 +++++++--- > 4 files changed, 365 insertions(+), 126 deletions(-) Unless Tom or Wolfgang object, I'm inclined to drop the objection to adding new hardware support to nand_spl in this case. I'd rather see the support be merged rather than ignored because a contributor has time for a small job but not a large one. Plus, this code will likely be reused by the new SPL support, if this platform is space constrained, so it's not dead-end effort. It would be nice, though, if the writenfc/readnfc conversion, comment reformatting, etc. were separate from the behavioral changes. -Scott