From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/11] DM: add block controller core
Date: Fri, 21 Sep 2012 14:51:33 +0200 [thread overview]
Message-ID: <201209211451.33805.marex@denx.de> (raw)
In-Reply-To: <11832942.v7278ihCq2@bloomfield>
Dear Pavel Herrmann,
> On Thursday 20 of September 2012 22:05:36 Marek Vasut wrote:
> > Dear Pavel Herrmann,
> >
> > > This core provides unified access to different block controllers (SATA,
> > > SCSI).
> >
> > Description of the patch missing or is sub-par. You should work on this
> > skill.
> >
> > > Signed-off-by: Pavel Herrmann <morpheus.ibis@gmail.com>
> > > ---
> > >
> > > Makefile | 1 +
> > > drivers/blockctrl/Makefile | 42 ++++++
> > > drivers/blockctrl/core.c | 349
> > >
> > > +++++++++++++++++++++++++++++++++++++++++++++ include/dm/blockctrl.h
> > > |
> > >
> > > 75 ++++++++++
> > > 4 files changed, 467 insertions(+)
> > > create mode 100644 drivers/blockctrl/Makefile
> > > create mode 100644 drivers/blockctrl/core.c
> > > create mode 100644 include/dm/blockctrl.h
> > >
> > > diff --git a/Makefile b/Makefile
> > > index e43fd9d..4420484 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -304,6 +304,7 @@ LIBS-y += test/libtest.o
> > >
> > > LIBS-$(CONFIG_DM) += common/dm/libdm.o
> > > LIBS-$(CONFIG_DM) += drivers/demo/libdemo.o
> > > LIBS-${CONFIG_DM_BLOCK} += drivers/blockdev/libblockdev.o
> > >
> > > +LIBS-${CONFIG_DM_BLOCK} += drivers/blockctrl/libblockctrl.o
> >
> > ${} ? What is this ?
Why not just reuse drivers/block and in drivers/block compile in the libblock.o
so you don't polute the top-level makefile ? Easy as that.
> > [..]
> >
> > This handles SCSI? Sata ? what ?
> >
> > Should this not be called scsi_core ? sata_core ? What did the previous
> > core do? sata? scsi? block? I'm lost.
>
> the previous core handled disks (and cards and stuff) and partitions (think
> /dev/sdxy), and was largely a replacement of /disk
> this core handles any interface those disks are connected to (SATA, PATA,
> SCSI), and should replace /drivers/block
Why is this not in the commit message then ? I have a proposal, before you
submit a patchset, prepare it, work on something else for a bit, then read again
the commit message only and see if you still understand what it means.
Am I correct that this will look as such:
user -> [ 01/11 ] -> [ 03/11 or something else ] -> [ if 03/11, then disc ]
> > I stop here, I don't know what this is all about, sorry.
> >
> > Best regards,
> > Marek Vasut
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-21 12:51 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 19:37 [U-Boot] [PATCH 00/11] Add DM blockdev subsystem Pavel Herrmann
2012-09-20 19:37 ` [U-Boot] [PATCH 01/11] DM: add block device core Pavel Herrmann
2012-09-20 19:58 ` Marek Vasut
2012-09-21 7:11 ` Pavel Herrmann
2012-09-21 12:39 ` Marek Vasut
2012-09-21 13:27 ` Pavel Herrmann
2012-09-21 13:53 ` Marek Vasut
2012-09-21 14:57 ` Pavel Herrmann
2012-09-21 15:34 ` Marek Vasut
2012-09-21 15:48 ` Pavel Herrmann
2012-09-21 15:55 ` Marek Vasut
2012-09-21 17:19 ` Pavel Herrmann
2012-09-21 18:00 ` Marek Vasut
2012-09-21 18:53 ` Pavel Herrmann
2012-09-21 19:17 ` Marek Vasut
2012-09-21 19:29 ` Pavel Herrmann
2012-09-21 21:11 ` Marek Vasut
2012-09-21 23:43 ` Pavel Herrmann
2012-09-22 0:09 ` Marek Vasut
2012-09-22 9:39 ` Pavel Herrmann
2012-09-22 13:33 ` Marek Vasut
2012-09-22 13:59 ` Pavel Herrmann
2012-09-24 12:23 ` Pavel Herrmann
2012-09-20 20:49 ` [U-Boot] [U-Boot-DM] " Vikram Narayanan
2012-09-21 7:09 ` Pavel Herrmann
2012-09-21 12:39 ` Marek Vasut
2012-09-20 19:37 ` [U-Boot] [PATCH 02/11] DM: add support for scanning DOS partitions to blockdev core Pavel Herrmann
2012-09-20 20:03 ` Marek Vasut
2012-09-21 7:22 ` Pavel Herrmann
2012-09-21 12:47 ` Marek Vasut
2012-09-21 13:18 ` Pavel Herrmann
2012-09-21 13:54 ` Marek Vasut
2012-09-20 19:37 ` [U-Boot] [PATCH 03/11] DM: add block controller core Pavel Herrmann
2012-09-20 20:05 ` Marek Vasut
2012-09-21 7:21 ` Pavel Herrmann
2012-09-21 12:51 ` Marek Vasut [this message]
2012-09-21 13:14 ` Pavel Herrmann
2012-09-21 13:56 ` Marek Vasut
2012-09-21 15:04 ` Pavel Herrmann
2012-09-21 13:33 ` Pavel Herrmann
2012-09-21 13:58 ` Marek Vasut
2012-09-21 15:09 ` Pavel Herrmann
2012-09-21 15:39 ` Marek Vasut
2012-09-21 15:46 ` Pavel Herrmann
2012-09-21 16:08 ` Marek Vasut
2012-09-21 17:22 ` Pavel Herrmann
2012-09-21 18:01 ` Marek Vasut
2012-09-21 19:15 ` Pavel Herrmann
2012-09-21 19:22 ` Marek Vasut
2012-09-20 19:37 ` [U-Boot] [PATCH 04/11] DM: add sata_legacy driver for blockctrl Pavel Herrmann
2012-09-20 19:37 ` [U-Boot] [PATCH 05/11] DM: add ata and partition blockdev drivers Pavel Herrmann
2012-09-20 19:37 ` [U-Boot] [PATCH 06/11] DM: add cmd_block command Pavel Herrmann
2012-09-20 19:37 ` [U-Boot] [PATCH 07/11] DM: use new blockdev API in FAT Pavel Herrmann
2012-09-20 19:37 ` [U-Boot] [PATCH 08/11] DM: use new blockdev API in ext2 Pavel Herrmann
2012-09-20 19:37 ` [U-Boot] [PATCH 09/11] DM: use new blockdev API in reiserfs Pavel Herrmann
2012-09-20 19:37 ` [U-Boot] [PATCH 10/11] DM: use new blockdev API in ZFS Pavel Herrmann
2012-09-20 19:37 ` [U-Boot] [PATCH 11/11] DM: switch sandbox to DM blockdev Pavel Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209211451.33805.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox