From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sun, 23 Sep 2012 17:43:49 +0200
Subject: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200
	palmtop
In-Reply-To: <1348410936-335-2-git-send-email-luk0104@gmail.com>
References: <1348410936-335-1-git-send-email-luk0104@gmail.com>
	<1348410936-335-2-git-send-email-luk0104@gmail.com>
Message-ID: <201209231743.49991.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Lukasz Dalek,

[...]

> +int dram_init(void)
> +{
> +	/*
> +	 * Everything except MSC0 was already set up by
> +	 * 1st stage bootloader
> +	 */
> +	clrsetbits_le32(MSC0, 0xffffffff, 0x246c7ffc);

This magic would use more description eventually.

> +	gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
> +	return 0;
> +}
> diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h
> new file mode 100644

Do you need this file at all? Can the udc_disconnect() not be put somewhere into 
usb.h ?

[...]

Rest seems fine, thanks.

Best regards,
Marek Vasut