[U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop

Marek Vasut
2012-09-24T01:23:46Z

Dear ?ukasz Da?ek,

> On 24.09.2012 01:25, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> >
> >> On 24.09.2012 01:05, Marek Vasut wrote:
> >>> Dear ?ukasz Da?ek,
> >>>
> >>>> On 23.09.2012 23:31, Marek Vasut wrote:
> >>>>> Dear ?ukasz Da?ek,
> >>>>>
> >>>>>> On 23.09.2012 23:04, Marek Vasut wrote:
> >>>>>>> PXA2xx is OHCI host with one OTG port.
> >>>>>>>
> >>>>>> From pxa255 documentation:
> >>>>>> "The UDC supports 16 endpoints and can operate half-duplex at a rate
> >>>>>> of 12 Mbps (as a slave only,
> >>>>>> not as a host or hub controller)."
> >>>>>>
> >>>>>>> what about include/usb/pxa27x_udc.h ... btw can't pxa27x and pxa25x
> >>>>>>> UDC use the same driver?
> >>>>>>
> >>>>>> pxa27x_udc driver is using older layer which doesn't work with usb
> >>>>>> ethernet driver.
> >>>>>>
> >>>>>> Btw. pxa27x can be host, pxa25x can't.
> >>>>>
> >>>>> Can you update the new gadget driver to be compatible with pxa27x
> >>>>> then ?
> >>>>
> >>>> I don't have any board with pxa27x processor. And I'm quite sure that
> >>>> differences between pxa25x and pxa27x usb are too big. Even in
> >>>> Linux kernel are two separate drivers for 25x and 27x chips.
> >>>
> >>> Isn't the 25x only a subset of the 27x ?
> >>
> >> Maybe it is.
> >>
> >> You've asked me if I could update driver to compatible with pxa27x and
> >> my answer is no. Maybe someone with pxa27x chip could.
> >
> > I can test it. It'd be good to have only one driver and get rid of the
> > old one seems to be the way to go.
>
> Does this driver work with usb ethernet gadget?

I have no idea, I never used it (and I'm not quite sure it's used at all). It's
a rotting piece of code, maybe we should throw it out altogether.

> >> I will left that h2200.h header. I'm sure that it will be helpful some
> >> day.
> >
> > For what exactly? Just put it into include/usb.h .
>
> I can't. It doesn't compile because of #error at 170 line.

You know ... #elif defined () is your friend there. Besides seriously, it'd be
very nice to share the error message if nothing else ...

> ?ukasz Da?ek

Best regards,
Marek Vasut