[U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop

Marek Vasut
2012-09-23T15:43:49Z

Dear Lukasz Dalek,

[...]

> +int dram_init(void)
> +{
> + /*
> + * Everything except MSC0 was already set up by
> + * 1st stage bootloader
> + */
> + clrsetbits_le32(MSC0, 0xffffffff, 0x246c7ffc);

This magic would use more description eventually.

> + gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
> + return 0;
> +}
> diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h
> new file mode 100644

Do you need this file at all? Can the udc_disconnect() not be put somewhere into
usb.h ?

[...]

Rest seems fine, thanks.

Best regards,
Marek Vasut