[U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop

Marek Vasut
2012-09-23T20:05:34Z

Dear ?ukasz Da?ek,

> On 23.09.2012 21:31, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> >
> >> On 23.09.2012 17:43, Marek Vasut wrote:
> >>>> + gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
> >>>> + return 0;
> >>>> +}
> >>>> diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h
> >>>> new file mode 100644
> >>>
> >>> Do you need this file at all? Can the udc_disconnect() not be put
> >>> somewhere into usb.h ?
> >>
> >> Can I just move this declaration into h2200.c?
> >
> > extern ... ? No, checkpatch will scream and extern is prohibited for a
> > good reason.
>
> So where should I put it?

Isn't it a general call? some include/usb.h ?

> ?ukasz Da?ek

Best regards,
Marek Vasut