From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/6] pxa25x: Add support for USB ethernet gadget
Date: Sun, 23 Sep 2012 21:32:56 +0200 [thread overview]
Message-ID: <201209232132.56272.marex@denx.de> (raw)
In-Reply-To: <505F59F9.1020301@gmail.com>
Dear ?ukasz Da?ek,
> On 23.09.2012 20:24, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> >
> >> On 23.09.2012 17:44, Marek Vasut wrote:
> >>> Dear Lukasz Dalek,
> >>>
> >>>> Add to pxa25x based devices support for USB ethernet gadget. This is a
> >>>> port of pxa25x UDC driver from Linux kernel.
> >>>>
> >>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
> >>>> ---
> >>>>
> >>>> drivers/usb/gadget/Makefile | 1 +
> >>>> drivers/usb/gadget/pxa25x_udc.c | 2059
> >>>>
> >>>> +++++++++++++++++++++++++++++++++++++++
> >>>> drivers/usb/gadget/pxa25x_udc.h
> >>>>
> >>>> | 162 +++
> >>>> |
> >>>> 3 files changed, 2222 insertions(+), 0 deletions(-)
> >>>> create mode 100644 drivers/usb/gadget/pxa25x_udc.c
> >>>> create mode 100644 drivers/usb/gadget/pxa25x_udc.h
> >>>
> >>> [...]
> >>>
> >>> So what's the change here? Or is it a repost?
> >>>
> >>> Best regards,
> >>> Marek Vasut
> >>
> >> Everything was fine except DEBUG_NOISY defintions. I fixed them and
> >> I have resend patch.
> >
> > http://www.denx.de/wiki/U-Boot/Patches did you read this? Worth reading
> > so I don't have to repeat myself ;-)
>
> Yes.
>
> >> Can I ask what about patches 3,4,5,6?
> >
> > I think they're fine ... did you do any changes to them ?
>
> If they are ok then my job is done :-)
You did not answer my question ... and no, your job isn't done ... once your
code is mainline, you're the maintainer, every change to common code will also
be your responsibility to at least review/test on your hardware etc ... you know
the drill.
Even though PXA is semi-dead, so I don't expect much happening there.
> ?ukasz Da?ek
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-23 19:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-23 14:35 [U-Boot] [PATCH v2 0/6] Add h2200 support and pxa25x ethernet gadget Lukasz Dalek
2012-09-23 14:35 ` [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop Lukasz Dalek
2012-09-23 15:43 ` Marek Vasut
2012-09-23 19:11 ` Łukasz Dałek
2012-09-23 19:31 ` Marek Vasut
2012-09-23 19:39 ` Łukasz Dałek
2012-09-23 20:05 ` Marek Vasut
2012-09-23 20:24 ` Łukasz Dałek
2012-09-23 20:52 ` Marek Vasut
2012-09-23 21:00 ` Łukasz Dałek
2012-09-23 21:04 ` Marek Vasut
2012-09-23 21:11 ` Łukasz Dałek
2012-09-23 21:31 ` Marek Vasut
2012-09-23 21:43 ` Łukasz Dałek
2012-09-23 23:05 ` Marek Vasut
2012-09-23 23:16 ` Łukasz Dałek
2012-09-23 23:25 ` Marek Vasut
2012-09-23 23:39 ` Łukasz Dałek
2012-09-24 1:23 ` Marek Vasut
2012-09-23 14:35 ` [U-Boot] [PATCH v2 2/6] pxa25x: Add support for USB ethernet gadget Lukasz Dalek
2012-09-23 15:44 ` Marek Vasut
2012-09-23 18:16 ` Łukasz Dałek
2012-09-23 18:24 ` Marek Vasut
2012-09-23 18:50 ` Łukasz Dałek
2012-09-23 19:32 ` Marek Vasut [this message]
2012-09-23 19:44 ` Łukasz Dałek
2012-09-23 20:05 ` Marek Vasut
2012-09-23 14:35 ` [U-Boot] [PATCH v2 3/6] pxa: Add some stuff to examine cpu model and rev Lukasz Dalek
2012-09-23 14:35 ` [U-Boot] [PATCH v2 4/6] usbether: Fixed bug when using with PXA25X chips Lukasz Dalek
2012-09-23 14:35 ` [U-Boot] [PATCH v2 5/6] usbether: Define CONFIG_USB_ETH_{CDC, SUBSET} Lukasz Dalek
2012-09-23 14:35 ` [U-Boot] [PATCH v2 6/6] usbether: Removed DEV_CONFIG_{CDC,SUBSET} Lukasz Dalek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209232132.56272.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox