From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sun, 23 Sep 2012 22:05:34 +0200
Subject: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200
	palmtop
In-Reply-To: <505F657D.6070603@gmail.com>
References: <1348410936-335-1-git-send-email-luk0104@gmail.com>
	<201209232131.40896.marex@denx.de> <505F657D.6070603@gmail.com>
Message-ID: <201209232205.34777.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear ?ukasz Da?ek,

> On 23.09.2012 21:31, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> > 
> >> On 23.09.2012 17:43, Marek Vasut wrote:
> >>>> +	gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
> >>>> +	return 0;
> >>>> +}
> >>>> diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h
> >>>> new file mode 100644
> >>> 
> >>> Do you need this file at all? Can the udc_disconnect() not be put
> >>> somewhere into usb.h ?
> >> 
> >> Can I just move this declaration into h2200.c?
> > 
> > extern ... ? No, checkpatch will scream and extern is prohibited for a
> > good reason.
> 
> So where should I put it?

Isn't it a general call? some include/usb.h ?

> ?ukasz Da?ek

Best regards,
Marek Vasut