From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sun, 23 Sep 2012 22:05:56 +0200
Subject: [U-Boot] [PATCH v2 2/6] pxa25x: Add support for USB ethernet
	gadget
In-Reply-To: <505F66BB.9040902@gmail.com>
References: <1348410936-335-1-git-send-email-luk0104@gmail.com>
	<201209232132.56272.marex@denx.de> <505F66BB.9040902@gmail.com>
Message-ID: <201209232205.56416.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear ?ukasz Da?ek,

> On 23.09.2012 21:32, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> > 
> >> On 23.09.2012 20:24, Marek Vasut wrote:
> >>> Dear ?ukasz Da?ek,
> >>> 
> >>>> On 23.09.2012 17:44, Marek Vasut wrote:
> >>>>> Dear Lukasz Dalek,
> >>>>> 
> >>>>>> Add to pxa25x based devices support for USB ethernet gadget. This is
> >>>>>> a port of pxa25x UDC driver from Linux kernel.
> >>>>>> 
> >>>>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
> >>>>>> ---
> >>>>>> 
> >>>>>>     drivers/usb/gadget/Makefile     |    1 +
> >>>>>>     drivers/usb/gadget/pxa25x_udc.c | 2059
> >>>>>> 
> >>>>>> +++++++++++++++++++++++++++++++++++++++
> >>>>>> drivers/usb/gadget/pxa25x_udc.h
> >>>>>> 
> >>>>>> | 162 +++
> >>>>>> | 
> >>>>>>     3 files changed, 2222 insertions(+), 0 deletions(-)
> >>>>>>     create mode 100644 drivers/usb/gadget/pxa25x_udc.c
> >>>>>>     create mode 100644 drivers/usb/gadget/pxa25x_udc.h
> >>>>> 
> >>>>> [...]
> >>>>> 
> >>>>> So what's the change here? Or is it a repost?
> >>>>> 
> >>>>> Best regards,
> >>>>> Marek Vasut
> >>>> 
> >>>> Everything was fine except DEBUG_NOISY defintions. I fixed them and
> >>>> I have resend patch.
> >>> 
> >>> http://www.denx.de/wiki/U-Boot/Patches did you read this? Worth reading
> >>> so I don't have to repeat myself ;-)
> >> 
> >> Yes.
> >> 
> >>>> Can I ask what about patches 3,4,5,6?
> >>> 
> >>> I think they're fine ... did you do any changes to them ?
> >> 
> >> If they are ok then my job is done :-)
> > 
> > You did not answer my question ... and no, your job isn't done ... once
> > your code is mainline, you're the maintainer, every change to common
> > code will also be your responsibility to at least review/test on your
> > hardware etc ... you know the drill.
> > 
> > Even though PXA is semi-dead, so I don't expect much happening there.
> 
> No, since last email I didn't change anything.
> 
> But for now you have said that they're fine, so all I have to wait. Am I
> wrong?

You're right.

> ?ukasz Da?ek

Best regards,
Marek Vasut