public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] common: Implement support for linker-generated arrays
Date: Mon, 24 Sep 2012 18:52:05 +0200	[thread overview]
Message-ID: <201209241852.05258.marex@denx.de> (raw)
In-Reply-To: <CANr=Z=am-z9X6t6qh7SFEa8neGm237eR8HC30Zke1gsdqVkZyg@mail.gmail.com>

Dear Joe Hershberger,

[...]

> > +#define ll_entry_declare(_type, _name, _section_u, _section_d)         \
> > +       _type _u_boot_list_##_section_u##_##_name __attribute__((       \
> > +                       unused, aligned(4),                             \
> > +                       section(".u_boot_list."#_section_d"."#_name))); \
> > +       _type _u_boot_list_##_section_u##_##_name
> 
> Why repeat the "_type _u_boot_list_##_section_u##_##_name" instead of
> just leaving the semicolon off after the __attribute__()?

Good idea. Do you like my documentation fairytail btw ? :p

> > +
> > +/**
> > + * ll_entry_start() - Point to first entry of linker-generated array
> > + * _type:      Data type of the entry
> > + * _section_u: Subsection of u_boot_list in which this entry is placed
> > + *             (with underscores instead of dots)
> > + *
> > + * This function returns (_type *) pointer to the very first entry of a
> > + * linker-generated array placed into subsection of .u_boot_list section
> > + * specified by _section_u argument.
> > + *
> > + * Example of usage:
> > + *
> > + * struct my_sub_cmd *msc = ll_entry_start(struct my_sub_cmd, cmd_sub);
> > + */
> > +#define ll_entry_start(_type, _section_u)                              \
> > +       ({                                                              \
> > +               extern _type _u_boot_list_##_section_u##__start;        \
> > +               _type *_ll_result = &_u_boot_list_##_section_u##__start;\
> > +               _ll_result;                                             \
> > +       })
> 
> Tricky.  I didn't realize this gcc extension existed.

All this is a horrible pile of tricks

[...]

  reply	other threads:[~2012-09-24 16:52 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24  1:21 [U-Boot] [RFC] [PATCH 0/3] Linker-generated arrays Marek Vasut
2012-09-24  1:21 ` [U-Boot] [PATCH 1/3] common: Add symbol handling for generic lists into Makefile Marek Vasut
2012-09-24 15:36   ` Joe Hershberger
2012-09-24 16:04     ` Marek Vasut
2012-09-24 17:00       ` Joe Hershberger
2012-09-24 17:08         ` Marek Vasut
2012-09-24 17:43           ` Joe Hershberger
2012-09-24  1:21 ` [U-Boot] [PATCH 2/3] common: Implement support for linker-generated arrays Marek Vasut
2012-09-24 16:30   ` Joe Hershberger
2012-09-24 16:52     ` Marek Vasut [this message]
2012-09-24  1:21 ` [U-Boot] [PATCH 3/3] common: Add .u_boot_list into all linker files Marek Vasut
2012-09-24 16:34   ` Joe Hershberger
2012-09-24 16:53     ` Marek Vasut
2012-09-24 17:06       ` Tom Rini
2012-09-24 17:09         ` Marek Vasut
2012-09-24 17:18           ` Tom Rini
2012-09-24 17:23             ` Joe Hershberger
2012-09-24 18:07               ` Tom Rini
2012-09-24 17:25             ` Marek Vasut
2012-09-24 17:29 ` [U-Boot] [RFC] [PATCH 0/3] Linker-generated arrays Tom Rini
2012-09-24 17:42   ` Marek Vasut
2012-09-25 16:11 ` [U-Boot] [RFC] [PATCH 0/3 v2] " Marek Vasut
2012-09-25 16:11   ` [U-Boot] [PATCH 1/3 V2] common: Add symbol handling for generic lists into Makefile Marek Vasut
2012-09-25 20:12     ` Wolfgang Denk
2012-09-25 20:22       ` Marek Vasut
2012-09-25 16:11   ` [U-Boot] [PATCH 2/3 V2] common: Implement support for linker-generated arrays Marek Vasut
2012-09-25 20:16     ` Wolfgang Denk
2012-09-25 20:24       ` Marek Vasut
2012-09-26  7:01         ` Wolfgang Denk
2012-09-26 16:53           ` Marek Vasut
2012-09-29  1:45     ` Joe Hershberger
2012-09-29  2:49       ` Marek Vasut
2012-09-25 16:12   ` [U-Boot] [PATCH 3/3 V2] common: Add .u_boot_list into all linker files Marek Vasut
2012-09-25 16:43     ` Otavio Salvador
2012-09-25 16:54       ` Marek Vasut
2012-09-25 20:17     ` Wolfgang Denk
2012-09-25 20:25       ` Marek Vasut
2012-09-29  1:34   ` [U-Boot] [PATCH 0/5 V2] Linker-generated arrays Marek Vasut
2012-09-29  1:34     ` [U-Boot] [PATCH 1/5] common: Add symbol handling for generic lists into Makefile Marek Vasut
2012-09-29  2:29       ` [U-Boot] [PATCH 1/5 V2] " Marek Vasut
2012-09-29  1:35     ` [U-Boot] [PATCH 2/5] common: Implement support for linker-generated arrays Marek Vasut
2012-09-29  1:35     ` [U-Boot] [PATCH 3/5] common: Add .u_boot_list into all linker files Marek Vasut
2012-09-29  1:35     ` [U-Boot] [PATCH 4/5] common: Convert the U-Boot commands to LG-arrays Marek Vasut
2012-09-29  1:35     ` [U-Boot] [PATCH 5/5] common: Discard the __u_boot_cmd section Marek Vasut
2012-09-29  2:44     ` [U-Boot] [PATCH 0/5 V2] Linker-generated arrays Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209241852.05258.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox