From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: arm1176: Define arch_cpu_init() at the SoC level
Date: Tue, 25 Sep 2012 13:30:30 -0700 [thread overview]
Message-ID: <20120925203030.GD24856@bill-the-cat> (raw)
In-Reply-To: <20120925220134.4755ef40@wker>
On Tue, Sep 25, 2012 at 10:01:34PM +0200, Anatolij Gustschin wrote:
> Hi Albert, Tom,
>
> On Sat, 1 Sep 2012 19:27:56 -0700
> Stephen Warren <swarren@wwwdotorg.org> wrote:
>
> > Commit 86c6326 "ARM: arm1176: enable instruction cache in
> > arch_cpu_init()" defined arch_cpu_init() in a file that is shared across
> > all arm1176 SoCs. tnetv107x already implemented this function, which
> > caused linking to break. Move the new conflicting arch_cpu_init() into
> > arm1176/bcm2835/init.c so that it doesn't conflict; grep indicates this
> > function is usually defined at the SoC-level, not the CPU-level, at least
> > for ARM.
> >
> > Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> > ---
> > arch/arm/cpu/arm1176/bcm2835/Makefile | 2 +-
> > arch/arm/cpu/arm1176/bcm2835/init.c | 24 ++++++++++++++++++++++++
> > arch/arm/cpu/arm1176/cpu.c | 7 -------
> > 3 files changed, 25 insertions(+), 8 deletions(-)
> > create mode 100644 arch/arm/cpu/arm1176/bcm2835/init.c
>
> Could you please apply this patch? It fixes the build error for
> tnetv107x_evm board. Currently MAKEALL doesn't build this board,
> but this [1] patch enables building it and it fails. Thanks!
I know this could go through u-boot-arm, but to try and ease Albert's
backlog, I've taken this for u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120925/00341255/attachment.pgp>
prev parent reply other threads:[~2012-09-25 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 2:27 [U-Boot] [PATCH] ARM: arm1176: Define arch_cpu_init() at the SoC level Stephen Warren
2012-09-14 0:17 ` Marek Vasut
2012-09-25 20:01 ` Anatolij Gustschin
2012-09-25 20:30 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925203030.GD24856@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox