From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h
Date: Wed, 26 Sep 2012 17:31:09 +0200 [thread overview]
Message-ID: <201209261731.09410.marex@denx.de> (raw)
In-Reply-To: <1348667065-27138-2-git-send-email-luk0104@gmail.com>
Dear Lukasz Dalek,
> PXA25x gadget implements common function usb_disconnect().
> This patch adds this function prototype into usb.h for boards using it.
[...]
> +/*
> + * This isn't host
> + */
The comment doesn't need to be multiline. It'd be cool if it was meaningful ...
like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise,
we're basically there.
Can you repost the whole patchset please?
> +#elif defined(CONFIG_USB_GADGET_PXA2XX)
> +
> +extern void udc_disconnect(void);
> +
> #else
> #error USB Lowlevel not defined
> #endif
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-26 15:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 13:44 [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop Lukasz Dalek
2012-09-26 13:44 ` [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h Lukasz Dalek
2012-09-26 15:31 ` Marek Vasut [this message]
2012-09-26 23:50 ` Łukasz Dałek
2012-09-26 23:58 ` Marek Vasut
2012-09-27 0:01 ` Łukasz Dałek
2012-09-27 0:06 ` Marek Vasut
2012-09-27 0:23 ` Łukasz Dałek
2012-09-27 0:30 ` Marek Vasut
2012-09-27 0:34 ` Łukasz Dałek
2012-09-26 15:29 ` [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop Marek Vasut
2012-09-26 16:08 ` Łukasz Dałek
2012-09-26 16:13 ` Marek Vasut
2012-09-26 20:58 ` Łukasz Dałek
2012-09-26 23:32 ` Marek Vasut
2012-09-26 23:47 ` Łukasz Dałek
2012-09-26 23:58 ` Marek Vasut
2012-09-27 0:03 ` Łukasz Dałek
2012-09-27 0:07 ` Marek Vasut
2012-09-27 0:15 ` Łukasz Dałek
2012-09-27 0:31 ` Marek Vasut
2012-09-27 0:35 ` Łukasz Dałek
2012-09-27 0:55 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209261731.09410.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox