public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/6] add zip command support for uboot
Date: Wed, 26 Sep 2012 17:34:25 +0200	[thread overview]
Message-ID: <201209261734.26146.marex@denx.de> (raw)
In-Reply-To: <CALZhoSRaWtz=VA=DRBifxfPFkSdcD3MhfZPCBndrvWbwXS-ADw@mail.gmail.com>

Dear Lei Wen,

> On Thu, Sep 6, 2012 at 6:49 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Lukasz Majewski,
> > 
> > [...]
> > 
> > > > Ok, that means we can make use of this command ?
> > > 
> > > I cannot promise, that I will provide the "zip" support straightaway in
> > > the DFU.
> > > 
> > > On the one hand if DFU is the only user of this command we are adding
> > > in fact a "dead" code.
> > > On the other hand we can use proper #define CONFIG_CMD_ZIP to not
> > > compile it until we "really" use this.
> > 
> > I'd rather see a user and code added, not the other way.
> 
> common/cmd_zip.c is another user. :)

I'm OK with this one.

> And file systems could use the zip callback to directly create the zipped
> file.

Definitelly not ... zip callback for FS is wrong.

> Since current ext4 and fat in uboot support write function, I think it
> could be
> a potential feature to add.

cmd_zip + fs write call is OK. But why do we need to zip anything in uboot, 
what's the usecase?


> > > Are there any other potential "users" of this functionality (ZIP
> > > compression/decompression) in u-boot?
> > 
> > None that I know of. Is it really zip or is it gzip ?
> 
> It is porting from zlib, and is there any different for the compression
> side for
> zip and gzip?

I ain't no expert, so I'm asking

> This patch is pending for too long time, do we have a answer now whether
> it could be merged?

Ccing Tom

> Thanks,
> Lei

Best regards,
Marek Vasut

  reply	other threads:[~2012-09-26 15:34 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-25 15:53 [U-Boot] [PATCH 0/6] add zip command support for uboot adrian.wenl at gmail.com
2012-03-25 15:53 ` [U-Boot] [PATCH 1/6] lib: zlib: import deflate source file from 1.2.5 adrian.wenl at gmail.com
2012-03-25 15:53 ` [U-Boot] [PATCH 2/6] lib: zlib: import trees " adrian.wenl at gmail.com
2012-03-25 15:53 ` [U-Boot] [PATCH 3/6] lib: zlib: include deflate into zlib build adrian.wenl at gmail.com
2012-03-25 15:53 ` [U-Boot] [PATCH 4/6] lib: zlib: remove the limitation for cannot using 0 as start adrian.wenl at gmail.com
2012-03-25 15:53 ` [U-Boot] [PATCH 5/6] lib: add gzip lib function callback adrian.wenl at gmail.com
2012-03-25 15:53 ` [U-Boot] [PATCH 6/6] common: add zip command support adrian.wenl at gmail.com
2012-03-27  8:04 ` [U-Boot] [PATCH 0/6] add zip command support for uboot Lei Wen
2012-03-27 18:12   ` Tom Rini
2012-03-28  2:23     ` Lei Wen
2012-04-02 14:16       ` Lei Wen
2012-04-02 19:17   ` Mike Frysinger
2012-04-03  9:31     ` Lei Wen
2012-04-10  4:37       ` Mike Frysinger
2012-04-10  5:05         ` Lei Wen
2012-04-10 22:11           ` Mike Frysinger
2012-04-11  1:24             ` Lei Wen
2012-05-08 12:57               ` Lei Wen
2012-06-21 19:12               ` Wolfgang Denk
2012-09-06  4:18 ` Marek Vasut
2012-09-06  4:49   ` Lei Wen
2012-09-06  6:23     ` Marek Vasut
2012-09-06  8:18       ` Lukasz Majewski
2012-09-06  8:49         ` Marek Vasut
2012-09-06 10:41           ` Lukasz Majewski
2012-09-06 10:49             ` Marek Vasut
2012-09-26  6:41               ` Lei Wen
2012-09-26 15:34                 ` Marek Vasut [this message]
2012-09-26 16:20                   ` Tom Rini
2012-09-27  2:05                     ` Lei Wen
2012-09-27 15:22                       ` Tom Rini
2012-09-28 14:29                         ` Lei Wen
2012-09-27  2:12                   ` Lei Wen
2012-09-28 14:26 ` [U-Boot] [PATCH V2 " Lei Wen
2012-09-29 14:51   ` Tom Rini
2012-09-28 14:26 ` [U-Boot] [PATCH V2 1/6] lib: zlib: import deflate source file from 1.2.5 Lei Wen
2012-09-28 14:26 ` [U-Boot] [PATCH V2 2/6] lib: zlib: import trees " Lei Wen
2012-09-28 14:26 ` [U-Boot] [PATCH V2 3/6] lib: zlib: include deflate into zlib build Lei Wen
2012-09-28 14:26 ` [U-Boot] [PATCH V2 4/6] lib: zlib: remove the limitation for cannot using 0 as start Lei Wen
2012-09-28 14:26 ` [U-Boot] [PATCH V2 5/6] lib: add gzip lib function callback Lei Wen
2012-09-28 14:26 ` [U-Boot] [PATCH V2 6/6] common: add zip command support Lei Wen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209261734.26146.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox