From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 26 Sep 2012 18:13:25 +0200 Subject: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop In-Reply-To: <5063287A.9010606@gmail.com> References: <1348667065-27138-1-git-send-email-luk0104@gmail.com> <201209261729.29069.marex@denx.de> <5063287A.9010606@gmail.com> Message-ID: <201209261813.25275.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear ?ukasz Da?ek, > On 26.09.2012 17:29, Marek Vasut wrote: > > Dear Lukasz Dalek, > > > >> Basic support of HP iPAQ h2200 palmtop. Support includes also USB > >> ethernet gadget. > > > > Two minor nits ... can you extend the patch description? > > > >> Signed-off-by: Lukasz Dalek > >> [...] > >> +h2200 arm pxa > >> +h2200_usbeth arm pxa h2200 > >> - > > > > Can you not enable USB ethernet by default? > > > > [...] > > I don't understand. > > make h2200_config creates config without usb ethernet > make h2200_usbeth_config creates config with usb ethernet Why not just make config with usb ethernet then? > ?ukasz Da?ek Best regards, Marek Vasut