From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop
Date: Thu, 27 Sep 2012 01:32:55 +0200 [thread overview]
Message-ID: <201209270132.55390.marex@denx.de> (raw)
In-Reply-To: <50636C72.7020703@gmail.com>
Dear ?ukasz Da?ek,
> On 26.09.2012 18:13, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> >
> >> On 26.09.2012 17:29, Marek Vasut wrote:
> >>> Dear Lukasz Dalek,
> >>>
> >>>> Basic support of HP iPAQ h2200 palmtop. Support includes also USB
> >>>> ethernet gadget.
> >>>
> >>> Two minor nits ... can you extend the patch description?
> >>>
> >>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
> >>>> [...]
> >>>> +h2200 arm pxa
> >>>> +h2200_usbeth arm pxa h2200
> >>>>
> >>>> -
> >>>
> >>> Can you not enable USB ethernet by default?
> >>>
> >>> [...]
> >>
> >> I don't understand.
> >>
> >> make h2200_config creates config without usb ethernet
> >> make h2200_usbeth_config creates config with usb ethernet
> >
> > Why not just make config with usb ethernet then?
>
> Sorry but I don't understand. You've asked me that can I not
> enable USB ethernet by default.
I think you misunderstood. I was never against enabling the USB ethernet. I was
against enabling it before the USB ethernet code is in, so it won't break
bisectability.
If I did really say so, I'm sorry for the confusion.
> When you type make h2200_config it won't be enabled.
> It will compile simple u-boot with nothing enabled but
> console and serial.
>
> When you type make h2200_usbeth_config then setup
> will define CONFIG_H2200_USBETH and compile h2200
> with usbeth support.
>
> So by default (with noting defined) it will compile simple
> h2200 support.
>
> ?ukasz Da?ek
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-26 23:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 13:44 [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop Lukasz Dalek
2012-09-26 13:44 ` [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h Lukasz Dalek
2012-09-26 15:31 ` Marek Vasut
2012-09-26 23:50 ` Łukasz Dałek
2012-09-26 23:58 ` Marek Vasut
2012-09-27 0:01 ` Łukasz Dałek
2012-09-27 0:06 ` Marek Vasut
2012-09-27 0:23 ` Łukasz Dałek
2012-09-27 0:30 ` Marek Vasut
2012-09-27 0:34 ` Łukasz Dałek
2012-09-26 15:29 ` [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop Marek Vasut
2012-09-26 16:08 ` Łukasz Dałek
2012-09-26 16:13 ` Marek Vasut
2012-09-26 20:58 ` Łukasz Dałek
2012-09-26 23:32 ` Marek Vasut [this message]
2012-09-26 23:47 ` Łukasz Dałek
2012-09-26 23:58 ` Marek Vasut
2012-09-27 0:03 ` Łukasz Dałek
2012-09-27 0:07 ` Marek Vasut
2012-09-27 0:15 ` Łukasz Dałek
2012-09-27 0:31 ` Marek Vasut
2012-09-27 0:35 ` Łukasz Dałek
2012-09-27 0:55 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209270132.55390.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox