From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 27 Sep 2012 01:58:29 +0200 Subject: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h In-Reply-To: <506394C2.4030001@gmail.com> References: <1348667065-27138-1-git-send-email-luk0104@gmail.com> <201209261731.09410.marex@denx.de> <506394C2.4030001@gmail.com> Message-ID: <201209270158.29506.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear ?ukasz Da?ek, > On 26.09.2012 17:31, Marek Vasut wrote: > > Dear Lukasz Dalek, > > > >> PXA25x gadget implements common function usb_disconnect(). > >> This patch adds this function prototype into usb.h for boards using it. > > > > [...] > > > >> +/* > >> + * This isn't host > >> + */ > > > > The comment doesn't need to be multiline. It'd be cool if it was > > meaningful ... like "pxa25x can only do gadget mode, thus the following > > ... etc". Otherwise, we're basically there. > > Ok > > > Can you repost the whole patchset please? > > Whole? Including ethernet driver, pxa cpu detection etc...? > If so, I'll resend them. Yes, in correct order please. We're almost there now. btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups etc? > ?ukasz Da?ek Best regards, Marek Vasut