From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h
Date: Thu, 27 Sep 2012 02:30:34 +0200 [thread overview]
Message-ID: <201209270230.34285.marex@denx.de> (raw)
In-Reply-To: <50639C77.4070500@gmail.com>
Dear ?ukasz Da?ek,
> On 27.09.2012 02:06, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> >
> >> On 27.09.2012 01:58, Marek Vasut wrote:
> >>> Dear ?ukasz Da?ek,
> >>>
> >>>> On 26.09.2012 17:31, Marek Vasut wrote:
> >>>>> Dear Lukasz Dalek,
> >>>>>
> >>>>>> PXA25x gadget implements common function usb_disconnect().
> >>>>>> This patch adds this function prototype into usb.h for boards using
> >>>>>> it.
> >>>>>
> >>>>> [...]
> >>>>>
> >>>>>> +/*
> >>>>>> + * This isn't host
> >>>>>> + */
> >>>>>
> >>>>> The comment doesn't need to be multiline. It'd be cool if it was
> >>>>> meaningful ... like "pxa25x can only do gadget mode, thus the
> >>>>> following ... etc". Otherwise, we're basically there.
> >>>>
> >>>> Ok
> >>>>
> >>>>> Can you repost the whole patchset please?
> >>>>
> >>>> Whole? Including ethernet driver, pxa cpu detection etc...?
> >>>> If so, I'll resend them.
> >>>
> >>> Yes, in correct order please. We're almost there now.
> >>>
> >>> btw. do you want to hack further on uboot? Maybe some PXA improvements
> >>> cleanups etc?
> >>
> >> Yes, but before I want to complete what I've started with h2200...
> >
> > You're basically there!
>
> What do you mean saying that I am there?
That you've walked most of the journey already, there's only the one small final
step for you to do ...
> > btw sorry if I sound a bit crazy, I've been pretty loaded recently so I
> > might have forgotten what I have told you a few days ago ...
>
> No problem.
>
> ?ukasz Da?ek
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-27 0:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 13:44 [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop Lukasz Dalek
2012-09-26 13:44 ` [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h Lukasz Dalek
2012-09-26 15:31 ` Marek Vasut
2012-09-26 23:50 ` Łukasz Dałek
2012-09-26 23:58 ` Marek Vasut
2012-09-27 0:01 ` Łukasz Dałek
2012-09-27 0:06 ` Marek Vasut
2012-09-27 0:23 ` Łukasz Dałek
2012-09-27 0:30 ` Marek Vasut [this message]
2012-09-27 0:34 ` Łukasz Dałek
2012-09-26 15:29 ` [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop Marek Vasut
2012-09-26 16:08 ` Łukasz Dałek
2012-09-26 16:13 ` Marek Vasut
2012-09-26 20:58 ` Łukasz Dałek
2012-09-26 23:32 ` Marek Vasut
2012-09-26 23:47 ` Łukasz Dałek
2012-09-26 23:58 ` Marek Vasut
2012-09-27 0:03 ` Łukasz Dałek
2012-09-27 0:07 ` Marek Vasut
2012-09-27 0:15 ` Łukasz Dałek
2012-09-27 0:31 ` Marek Vasut
2012-09-27 0:35 ` Łukasz Dałek
2012-09-27 0:55 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209270230.34285.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox