[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Lukasz Dalek]

Basic support of HP iPAQ h2200 palmtop. Support includes also USB
ethernet gadget.

Signed-off-by: Lukasz Dalek <luk0104@gmail.com>
---
 board/h2200/Makefile       |   51 ++++++++++++
 board/h2200/h2200-header.S |   27 ++++++
 board/h2200/h2200.c        |   66 +++++++++++++++
 boards.cfg                 |    2 +
 include/configs/h2200.h    |  189 ++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 335 insertions(+), 0 deletions(-)
 create mode 100644 board/h2200/Makefile
 create mode 100644 board/h2200/h2200-header.S
 create mode 100644 board/h2200/h2200.c
 create mode 100644 include/configs/h2200.h

diff --git a/board/h2200/Makefile b/board/h2200/Makefile
new file mode 100644
index 0000000..2265aa9
--- /dev/null
+++ b/board/h2200/Makefile
@@ -0,0 +1,51 @@
+#
+# h2200 Support
+#
+# Copyright (C) 2012 Lukasz Dalek <luk0104@gmail.com>
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).o
+
+COBJS	:= h2200.o
+
+SRCS	:= $(COBJS:.o=.c) h2200-header.S
+OBJS	:= $(addprefix $(obj),$(COBJS))
+
+ALL: $(LIB) h2200-header.bin
+
+h2200-header.o: h2200-header.S
+	$(CC) $(CFLAGS) -c -o $@ $<
+
+h2200-header.bin: h2200-header.o
+	$(OBJCOPY) -O binary $< $@
+
+all: $(LIB) h2200-header.bin
+
+$(LIB):	$(obj).depend $(OBJS)
+	$(call cmd_link_o_target, $(OBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
diff --git a/board/h2200/h2200-header.S b/board/h2200/h2200-header.S
new file mode 100644
index 0000000..c335bfe
--- /dev/null
+++ b/board/h2200/h2200-header.S
@@ -0,0 +1,27 @@
+/*
+ * iPAQ h2200 header
+ *
+ * Copyright (C) 2012 Lukasz Dalek <luk0104@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+
+	.word 0xea0003fe /* b 0x1000 */
+
+	.org 0x40
+	.ascii "ECEC"
+
+	.org 0x1000 - 1
+	.byte 0x0
diff --git a/board/h2200/h2200.c b/board/h2200/h2200.c
new file mode 100644
index 0000000..2ae2670
--- /dev/null
+++ b/board/h2200/h2200.c
@@ -0,0 +1,66 @@
+/*
+ * iPAQ h2200 board configuration
+ *
+ * Copyright (C) 2012 Lukasz Dalek <luk0104@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+
+#include <common.h>
+#include <asm/arch/pxa.h>
+#include <asm/arch/pxa-regs.h>
+#include <asm/io.h>
+#include <usb.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#ifdef CONFIG_H2200_USBETH
+int board_eth_init(bd_t *bis)
+{
+	usb_eth_initialize(bis);
+	return 0;
+}
+#endif
+
+int board_init(void)
+{
+	/* We have RAM, disable cache */
+	dcache_disable();
+	icache_disable();
+
+	gd->bd->bi_arch_number = MACH_TYPE_H2200;
+
+	/* adress of boot parameters */
+	gd->bd->bi_boot_params = 0xa0000100;
+
+	/* Let host see that device is disconnected */
+#if defined(CONFIG_H2200_USBETH)
+	udc_disconnect();
+	mdelay(500);
+#endif
+
+	return 0;
+}
+
+int dram_init(void)
+{
+	/*
+	 * Everything except MSC0 was already set up by
+	 * 1st stage bootloader
+	 */
+	clrsetbits_le32(MSC0, 0xffffffff, 0x246c7ffc);
+	gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
+	return 0;
+}
diff --git a/boards.cfg b/boards.cfg
index b4e0d3c..a03a469 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -282,6 +282,8 @@ dvlhost                      arm         ixp
 pdnb3                        arm         ixp         pdnb3               prodrive
 scpu                         arm         ixp         pdnb3               prodrive       -           pdnb3:SCPU
 balloon3                     arm         pxa
+h2200                        arm         pxa
+h2200_usbeth                 arm         pxa         h2200               -              -           h2200:H2200_USBETH
 lubbock                      arm         pxa
 palmld                       arm         pxa
 palmtc                       arm         pxa
diff --git a/include/configs/h2200.h b/include/configs/h2200.h
new file mode 100644
index 0000000..1062ec0
--- /dev/null
+++ b/include/configs/h2200.h
@@ -0,0 +1,189 @@
+/*
+ * iPAQ h2200 board configuration
+ *
+ * Copyright (C) 2012 Lukasz Dalek <luk0104@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#define MACH_TYPE_H2200			341
+#define CONFIG_MACH_TYPE		MACH_TYPE_H2200
+
+#define CONFIG_CPU_PXA25X		1
+#define CONFIG_BOARD_H2200
+
+#define CONFIG_SYS_NO_FLASH
+
+#define CONFIG_SYS_HZ			1000
+
+#define CONFIG_NR_DRAM_BANKS		1
+#define PHYS_SDRAM_1			0xa0000000 /* SDRAM Bank #1 */
+#define PHYS_SDRAM_1_SIZE		0x04000000 /* 64 MB */
+
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+#define CONFIG_SYS_SDRAM_SIZE		PHYS_SDRAM_1_SIZE
+
+#define CONFIG_SYS_INIT_SP_ADDR		0xfffff800
+
+#define CONFIG_ENV_SIZE			0x00040000
+#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + 128*1024)
+
+#define CONFIG_ENV_IS_NOWHERE
+#define CONFIG_SYS_MAXARGS		16
+#define CONFIG_SYS_LOAD_ADDR		0xa3000000 /* default load address */
+
+/*
+ * iPAQ 1st stage bootloader loads 2nd stage bootloader
+ * at address 0xa0040000 but bootloader requires header
+ * which is 0x1000 long.
+ *
+ * --- Header begin ---
+ *	.word 0xea0003fe ; b 0x1000
+ *
+ *	.org 0x40
+ *	.ascii "ECEC"
+ *
+ *	.org 0x1000
+ * --- Header end ---
+ */
+
+#define CONFIG_SYS_TEXT_BASE		0xa0041000
+
+/*
+ * Static chips
+ */
+
+#define CONFIG_SYS_MSC0_VAL		0x246c7ffc
+#define CONFIG_SYS_MSC1_VAL		0x7ff07ff0
+#define CONFIG_SYS_MSC2_VAL		0x7ff07ff0
+
+/*
+ * PCMCIA and CF Interfaces
+ */
+
+#define CONFIG_SYS_MECR_VAL		0x00000000
+#define CONFIG_SYS_MCMEM0_VAL		0x00000000
+#define CONFIG_SYS_MCMEM1_VAL		0x00000000
+#define CONFIG_SYS_MCATT0_VAL		0x00000000
+#define CONFIG_SYS_MCATT1_VAL		0x00000000
+#define CONFIG_SYS_MCIO0_VAL		0x00000000
+#define CONFIG_SYS_MCIO1_VAL		0x00000000
+
+#define CONFIG_SYS_FLYCNFG_VAL		0x00000000
+#define CONFIG_SYS_SXCNFG_VAL		0x00040004
+
+#define CONFIG_SYS_MDREFR_VAL		0x0099E018
+#define CONFIG_SYS_MDCNFG_VAL		0x01C801CB
+#define CONFIG_SYS_MDMRS_VAL		0x00220022
+
+#define CONFIG_SYS_PSSR_VAL		0x00000000
+#define CONFIG_SYS_CKEN			0x00004840
+#define CONFIG_SYS_CCCR			0x00000161
+
+/*
+ * GPIOs
+ */
+
+#define CONFIG_SYS_GPSR0_VAL		0x01000000
+#define CONFIG_SYS_GPSR1_VAL		0x00000000
+#define CONFIG_SYS_GPSR2_VAL		0x00010000
+
+#define CONFIG_SYS_GPCR0_VAL		0x00000000
+#define CONFIG_SYS_GPCR1_VAL		0x00000000
+#define CONFIG_SYS_GPCR2_VAL		0x00000000
+
+#define CONFIG_SYS_GPDR0_VAL		0xF7E38C00
+#define CONFIG_SYS_GPDR1_VAL		0xBCFFBF83
+#define CONFIG_SYS_GPDR2_VAL		0x000157FF
+
+#define CONFIG_SYS_GAFR0_L_VAL		0x80401000
+#define CONFIG_SYS_GAFR0_U_VAL		0x00000112
+#define CONFIG_SYS_GAFR1_L_VAL		0x600A9550
+#define CONFIG_SYS_GAFR1_U_VAL		0x0005AAAA
+#define CONFIG_SYS_GAFR2_L_VAL		0x20000000
+#define CONFIG_SYS_GAFR2_U_VAL		0x00000000
+
+/*
+ * Serial port
+ */
+
+#define CONFIG_PXA_SERIAL
+#define CONFIG_FFUART
+
+#define CONFIG_BAUDRATE			115200
+#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 38400, 115200 }
+
+/*
+ * USB device configuration
+ */
+
+#define CONFIG_SYS_CONSOLE_IS_IN_ENV
+#define CONFIG_USB_DEV_PULLUP_GPIO	33
+/* USB VBUS GPIO 3 */
+
+#define CONFIG_CMD_LOADB
+#define CONFIG_CMD_IMPORTENV		1
+#define CONFIG_CMD_SOURCE
+#define CONFIG_CMD_RUN
+#define CONFIG_CMD_IMI
+
+/* Monitor Command Prompt */
+#define CONFIG_SYS_PROMPT		"> "
+
+/* Console I/O Buffer Size */
+#define CONFIG_SYS_CBSIZE		256
+
+/* Print Buffer Size */
+#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
+					sizeof(CONFIG_SYS_PROMPT) + 16)
+
+#define CONFIG_BOOTARGS "root=/dev/ram0 ro console=ttyS0,115200n8"
+
+#ifdef CONFIG_H2200_USBETH
+# define CONFIG_USB_ETH_SUBSET
+# define CONFIG_SYS_HUSH_PARSER
+# define CONFIG_SYS_PROMPT_HUSH_PS2	"$ "
+
+# define CONFIG_CMD_NET
+# define CONFIG_CMD_PING
+
+# define CONFIG_BOOTDELAY		2
+
+# define CONFIG_BOOTCOMMAND		\
+	"setenv downloaded 0 ; while test $downloaded -eq 0 ; do " \
+	"if bootp ; then setenv downloaded 1 ; fi ; done ; " \
+	"source :script ; " \
+	"bootm ; "
+
+# define CONFIG_USB_GADGET_PXA2XX
+
+# define CONFIG_FIT
+# define CONFIG_SETUP_MEMORY_TAGS
+# define CONFIG_CMDLINE_TAG
+# define CONFIG_INITRD_TAG
+
+# define CONFIG_USB_ETHER
+# define CONFIG_USBNET_DEV_ADDR		"de:ad:be:ef:00:01"
+# define CONFIG_USBNET_HOST_ADDR	"de:ad:be:ef:00:02"
+# define CONFIG_EXTRA_ENV_SETTINGS \
+	"stdin=serial\0" \
+	"stdout=serial\0" \
+	"stderr=serial\0"
+#endif
+
+#endif /* __CONFIG_H */
-- 
1.7.8.6

[U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

[Lukasz Dalek]

PXA25x gadget implements common function usb_disconnect().
This patch adds this function prototype into usb.h for boards using it.

Signed-off-by: Lukasz Dalek <luk0104@gmail.com>
---
 include/usb.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/include/usb.h b/include/usb.h
index ba3d169..25c3255 100644
--- a/include/usb.h
+++ b/include/usb.h
@@ -166,6 +166,13 @@ int submit_int_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
 #define USB_UHCI_VEND_ID	0x8086
 #define USB_UHCI_DEV_ID		0x7112
 
+/*
+ * This isn't host
+ */
+#elif defined(CONFIG_USB_GADGET_PXA2XX)
+
+extern void udc_disconnect(void);
+
 #else
 #error USB Lowlevel not defined
 #endif
-- 
1.7.8.6

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Marek Vasut]

Dear Lukasz Dalek,

> Basic support of HP iPAQ h2200 palmtop. Support includes also USB
> ethernet gadget.

Two minor nits ... can you extend the patch description?

> Signed-off-by: Lukasz Dalek <luk0104@gmail.com>

> [...]
> +h2200                        arm         pxa
> +h2200_usbeth                 arm         pxa         h2200               -

Can you not enable USB ethernet by default?

[...]

Best regards,
Marek Vasut

[U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

[Marek Vasut]

Dear Lukasz Dalek,

> PXA25x gadget implements common function usb_disconnect().
> This patch adds this function prototype into usb.h for boards using it.

[...]

> +/*
> + * This isn't host
> + */

The comment doesn't need to be multiline. It'd be cool if it was meaningful ... 
like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise, 
we're basically there.

Can you repost the whole patchset please?

> +#elif defined(CONFIG_USB_GADGET_PXA2XX)
> +
> +extern void udc_disconnect(void);
> +
>  #else
>  #error USB Lowlevel not defined
>  #endif

Best regards,
Marek Vasut

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Łukasz Dałek]

On 26.09.2012 17:29, Marek Vasut wrote:
> Dear Lukasz Dalek,
>
>> Basic support of HP iPAQ h2200 palmtop. Support includes also USB
>> ethernet gadget.
> Two minor nits ... can you extend the patch description?
>
>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
>> [...]
>> +h2200                        arm         pxa
>> +h2200_usbeth                 arm         pxa         h2200               -
> Can you not enable USB ethernet by default?
>
> [...]

I don't understand.

make h2200_config creates config without usb ethernet
make h2200_usbeth_config creates config with usb ethernet

?ukasz Da?ek

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Marek Vasut]

Dear ?ukasz Da?ek,

> On 26.09.2012 17:29, Marek Vasut wrote:
> > Dear Lukasz Dalek,
> > 
> >> Basic support of HP iPAQ h2200 palmtop. Support includes also USB
> >> ethernet gadget.
> > 
> > Two minor nits ... can you extend the patch description?
> > 
> >> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
> >> [...]
> >> +h2200                        arm         pxa
> >> +h2200_usbeth                 arm         pxa         h2200             
> >>  -
> > 
> > Can you not enable USB ethernet by default?
> > 
> > [...]
> 
> I don't understand.
> 
> make h2200_config creates config without usb ethernet
> make h2200_usbeth_config creates config with usb ethernet

Why not just make config with usb ethernet then?

> ?ukasz Da?ek

Best regards,
Marek Vasut

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Łukasz Dałek]

On 26.09.2012 18:13, Marek Vasut wrote:
> Dear ?ukasz Da?ek,
>
>> On 26.09.2012 17:29, Marek Vasut wrote:
>>> Dear Lukasz Dalek,
>>>
>>>> Basic support of HP iPAQ h2200 palmtop. Support includes also USB
>>>> ethernet gadget.
>>> Two minor nits ... can you extend the patch description?
>>>
>>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
>>>> [...]
>>>> +h2200                        arm         pxa
>>>> +h2200_usbeth                 arm         pxa         h2200
>>>>   -
>>> Can you not enable USB ethernet by default?
>>>
>>> [...]
>> I don't understand.
>>
>> make h2200_config creates config without usb ethernet
>> make h2200_usbeth_config creates config with usb ethernet
> Why not just make config with usb ethernet then?
>
Sorry but I don't understand. You've asked me that can I not
enable USB ethernet by default.

When you type make h2200_config it won't be enabled.
It will compile simple u-boot with nothing enabled but
console and serial.

When you type make h2200_usbeth_config then setup
will define CONFIG_H2200_USBETH and compile h2200
with usbeth support.

So by default (with noting defined) it will compile simple
h2200 support.

?ukasz Da?ek

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Marek Vasut]

Dear ?ukasz Da?ek,

> On 26.09.2012 18:13, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> > 
> >> On 26.09.2012 17:29, Marek Vasut wrote:
> >>> Dear Lukasz Dalek,
> >>> 
> >>>> Basic support of HP iPAQ h2200 palmtop. Support includes also USB
> >>>> ethernet gadget.
> >>> 
> >>> Two minor nits ... can you extend the patch description?
> >>> 
> >>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
> >>>> [...]
> >>>> +h2200                        arm         pxa
> >>>> +h2200_usbeth                 arm         pxa         h2200
> >>>> 
> >>>>   -
> >>> 
> >>> Can you not enable USB ethernet by default?
> >>> 
> >>> [...]
> >> 
> >> I don't understand.
> >> 
> >> make h2200_config creates config without usb ethernet
> >> make h2200_usbeth_config creates config with usb ethernet
> > 
> > Why not just make config with usb ethernet then?
> 
> Sorry but I don't understand. You've asked me that can I not
> enable USB ethernet by default.

I think you misunderstood. I was never against enabling the USB ethernet. I was 
against enabling it before the USB ethernet code is in, so it won't break 
bisectability.

If I did really say so, I'm sorry for the confusion.

> When you type make h2200_config it won't be enabled.
> It will compile simple u-boot with nothing enabled but
> console and serial.
> 
> When you type make h2200_usbeth_config then setup
> will define CONFIG_H2200_USBETH and compile h2200
> with usbeth support.
> 
> So by default (with noting defined) it will compile simple
> h2200 support.
> 
> ?ukasz Da?ek

Best regards,
Marek Vasut

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Łukasz Dałek]

On 27.09.2012 01:32, Marek Vasut wrote:
> Dear ?ukasz Da?ek,
>
>> On 26.09.2012 18:13, Marek Vasut wrote:
>>> Dear ?ukasz Da?ek,
>>>
>>>> On 26.09.2012 17:29, Marek Vasut wrote:
>>>>> Dear Lukasz Dalek,
>>>>>
>>>>>> Basic support of HP iPAQ h2200 palmtop. Support includes also USB
>>>>>> ethernet gadget.
>>>>> Two minor nits ... can you extend the patch description?
>>>>>
>>>>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
>>>>>> [...]
>>>>>> +h2200                        arm         pxa
>>>>>> +h2200_usbeth                 arm         pxa         h2200
>>>>>>
>>>>>>    -
>>>>> Can you not enable USB ethernet by default?
>>>>>
>>>>> [...]
>>>> I don't understand.
>>>>
>>>> make h2200_config creates config without usb ethernet
>>>> make h2200_usbeth_config creates config with usb ethernet
>>> Why not just make config with usb ethernet then?
>> Sorry but I don't understand. You've asked me that can I not
>> enable USB ethernet by default.
> I think you misunderstood. I was never against enabling the USB ethernet. I was
> against enabling it before the USB ethernet code is in, so it won't break
> bisectability.
>
> If I did really say so, I'm sorry for the confusion.
So you want from me to split h2200 patches? I mean to prepare 2 patches:
1st one only adding support for device and 2nd one adding support for
ethernet?

?ukasz Da?ek

[U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

[Łukasz Dałek]

On 26.09.2012 17:31, Marek Vasut wrote:
> Dear Lukasz Dalek,
>
>> PXA25x gadget implements common function usb_disconnect().
>> This patch adds this function prototype into usb.h for boards using it.
> [...]
>
>> +/*
>> + * This isn't host
>> + */
> The comment doesn't need to be multiline. It'd be cool if it was meaningful ...
> like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise,
> we're basically there.

Ok

>
> Can you repost the whole patchset please?

Whole? Including ethernet driver, pxa cpu detection etc...?
If so, I'll resend them.

?ukasz Da?ek

[U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

[Marek Vasut]

Dear ?ukasz Da?ek,

> On 26.09.2012 17:31, Marek Vasut wrote:
> > Dear Lukasz Dalek,
> > 
> >> PXA25x gadget implements common function usb_disconnect().
> >> This patch adds this function prototype into usb.h for boards using it.
> > 
> > [...]
> > 
> >> +/*
> >> + * This isn't host
> >> + */
> > 
> > The comment doesn't need to be multiline. It'd be cool if it was
> > meaningful ... like "pxa25x can only do gadget mode, thus the following
> > ... etc". Otherwise, we're basically there.
> 
> Ok
> 
> > Can you repost the whole patchset please?
> 
> Whole? Including ethernet driver, pxa cpu detection etc...?
> If so, I'll resend them.

Yes, in correct order please. We're almost there now.

btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups 
etc?

> ?ukasz Da?ek

Best regards,
Marek Vasut

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Marek Vasut]

Dear ?ukasz Da?ek,

> On 27.09.2012 01:32, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> > 
> >> On 26.09.2012 18:13, Marek Vasut wrote:
> >>> Dear ?ukasz Da?ek,
> >>> 
> >>>> On 26.09.2012 17:29, Marek Vasut wrote:
> >>>>> Dear Lukasz Dalek,
> >>>>> 
> >>>>>> Basic support of HP iPAQ h2200 palmtop. Support includes also USB
> >>>>>> ethernet gadget.
> >>>>> 
> >>>>> Two minor nits ... can you extend the patch description?
> >>>>> 
> >>>>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
> >>>>>> [...]
> >>>>>> +h2200                        arm         pxa
> >>>>>> +h2200_usbeth                 arm         pxa         h2200
> >>>>>> 
> >>>>>>    -
> >>>>> 
> >>>>> Can you not enable USB ethernet by default?
> >>>>> 
> >>>>> [...]
> >>>> 
> >>>> I don't understand.
> >>>> 
> >>>> make h2200_config creates config without usb ethernet
> >>>> make h2200_usbeth_config creates config with usb ethernet
> >>> 
> >>> Why not just make config with usb ethernet then?
> >> 
> >> Sorry but I don't understand. You've asked me that can I not
> >> enable USB ethernet by default.
> > 
> > I think you misunderstood. I was never against enabling the USB ethernet.
> > I was against enabling it before the USB ethernet code is in, so it
> > won't break bisectability.
> > 
> > If I did really say so, I'm sorry for the confusion.
> 
> So you want from me to split h2200 patches? I mean to prepare 2 patches:
> 1st one only adding support for device and 2nd one adding support for
> ethernet?

Oh, that would work nicely, good idea.

> ?ukasz Da?ek

Best regards,
Marek Vasut

[U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

[Łukasz Dałek]

On 27.09.2012 01:58, Marek Vasut wrote:
> Dear ?ukasz Da?ek,
>
>> On 26.09.2012 17:31, Marek Vasut wrote:
>>> Dear Lukasz Dalek,
>>>
>>>> PXA25x gadget implements common function usb_disconnect().
>>>> This patch adds this function prototype into usb.h for boards using it.
>>> [...]
>>>
>>>> +/*
>>>> + * This isn't host
>>>> + */
>>> The comment doesn't need to be multiline. It'd be cool if it was
>>> meaningful ... like "pxa25x can only do gadget mode, thus the following
>>> ... etc". Otherwise, we're basically there.
>> Ok
>>
>>> Can you repost the whole patchset please?
>> Whole? Including ethernet driver, pxa cpu detection etc...?
>> If so, I'll resend them.
> Yes, in correct order please. We're almost there now.
>
> btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups
> etc?

Yes, but before I want to complete what I've started with h2200...

?ukasz Da?ek

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Łukasz Dałek]

On 27.09.2012 01:58, Marek Vasut wrote:
> Dear ?ukasz Da?ek,
>
>> On 27.09.2012 01:32, Marek Vasut wrote:
>>> Dear ?ukasz Da?ek,
>>>
>>>> On 26.09.2012 18:13, Marek Vasut wrote:
>>>>> Dear ?ukasz Da?ek,
>>>>>
>>>>>> On 26.09.2012 17:29, Marek Vasut wrote:
>>>>>>> Dear Lukasz Dalek,
>>>>>>>
>>>>>>>> Basic support of HP iPAQ h2200 palmtop. Support includes also USB
>>>>>>>> ethernet gadget.
>>>>>>> Two minor nits ... can you extend the patch description?
>>>>>>>
>>>>>>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
>>>>>>>> [...]
>>>>>>>> +h2200                        arm         pxa
>>>>>>>> +h2200_usbeth                 arm         pxa         h2200
>>>>>>>>
>>>>>>>>     -
>>>>>>> Can you not enable USB ethernet by default?
>>>>>>>
>>>>>>> [...]
>>>>>> I don't understand.
>>>>>>
>>>>>> make h2200_config creates config without usb ethernet
>>>>>> make h2200_usbeth_config creates config with usb ethernet
>>>>> Why not just make config with usb ethernet then?
>>>> Sorry but I don't understand. You've asked me that can I not
>>>> enable USB ethernet by default.
>>> I think you misunderstood. I was never against enabling the USB ethernet.
>>> I was against enabling it before the USB ethernet code is in, so it
>>> won't break bisectability.
>>>
>>> If I did really say so, I'm sorry for the confusion.
>> So you want from me to split h2200 patches? I mean to prepare 2 patches:
>> 1st one only adding support for device and 2nd one adding support for
>> ethernet?
> Oh, that would work nicely, good idea.

Ok, I will prepare them. But not sooner than tommorow.

?ukasz Da?ek

[U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

[Marek Vasut]

Dear ?ukasz Da?ek,

> On 27.09.2012 01:58, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> > 
> >> On 26.09.2012 17:31, Marek Vasut wrote:
> >>> Dear Lukasz Dalek,
> >>> 
> >>>> PXA25x gadget implements common function usb_disconnect().
> >>>> This patch adds this function prototype into usb.h for boards using
> >>>> it.
> >>> 
> >>> [...]
> >>> 
> >>>> +/*
> >>>> + * This isn't host
> >>>> + */
> >>> 
> >>> The comment doesn't need to be multiline. It'd be cool if it was
> >>> meaningful ... like "pxa25x can only do gadget mode, thus the following
> >>> ... etc". Otherwise, we're basically there.
> >> 
> >> Ok
> >> 
> >>> Can you repost the whole patchset please?
> >> 
> >> Whole? Including ethernet driver, pxa cpu detection etc...?
> >> If so, I'll resend them.
> > 
> > Yes, in correct order please. We're almost there now.
> > 
> > btw. do you want to hack further on uboot? Maybe some PXA improvements
> > cleanups etc?
> 
> Yes, but before I want to complete what I've started with h2200...

You're basically there!

btw sorry if I sound a bit crazy, I've been pretty loaded recently so I might 
have forgotten what I have told you a few days ago ...

> ?ukasz Da?ek

Best regards,
Marek Vasut

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Marek Vasut]

Dear ?ukasz Da?ek,

> On 27.09.2012 01:58, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> > 
> >> On 27.09.2012 01:32, Marek Vasut wrote:
> >>> Dear ?ukasz Da?ek,
> >>> 
> >>>> On 26.09.2012 18:13, Marek Vasut wrote:
> >>>>> Dear ?ukasz Da?ek,
> >>>>> 
> >>>>>> On 26.09.2012 17:29, Marek Vasut wrote:
> >>>>>>> Dear Lukasz Dalek,
> >>>>>>> 
> >>>>>>>> Basic support of HP iPAQ h2200 palmtop. Support includes also USB
> >>>>>>>> ethernet gadget.
> >>>>>>> 
> >>>>>>> Two minor nits ... can you extend the patch description?
> >>>>>>> 
> >>>>>>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
> >>>>>>>> [...]
> >>>>>>>> +h2200                        arm         pxa
> >>>>>>>> +h2200_usbeth                 arm         pxa         h2200
> >>>>>>>> 
> >>>>>>>>     -
> >>>>>>> 
> >>>>>>> Can you not enable USB ethernet by default?
> >>>>>>> 
> >>>>>>> [...]
> >>>>>> 
> >>>>>> I don't understand.
> >>>>>> 
> >>>>>> make h2200_config creates config without usb ethernet
> >>>>>> make h2200_usbeth_config creates config with usb ethernet
> >>>>> 
> >>>>> Why not just make config with usb ethernet then?
> >>>> 
> >>>> Sorry but I don't understand. You've asked me that can I not
> >>>> enable USB ethernet by default.
> >>> 
> >>> I think you misunderstood. I was never against enabling the USB
> >>> ethernet. I was against enabling it before the USB ethernet code is
> >>> in, so it won't break bisectability.
> >>> 
> >>> If I did really say so, I'm sorry for the confusion.
> >> 
> >> So you want from me to split h2200 patches? I mean to prepare 2 patches:
> >> 1st one only adding support for device and 2nd one adding support for
> >> ethernet?
> > 
> > Oh, that would work nicely, good idea.
> 
> Ok, I will prepare them. But not sooner than tommorow.

Take your time ... PXA won't run anywhere anyway. btw. you're polish? I might 
actually find you some old PXA device.

> ?ukasz Da?ek

Best regards,
Marek Vasut

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Łukasz Dałek]

On 27.09.2012 02:07, Marek Vasut wrote:
> Dear ?ukasz Da?ek,
>
>> On 27.09.2012 01:58, Marek Vasut wrote:
>>> Dear ?ukasz Da?ek,
>>>
>>>> On 27.09.2012 01:32, Marek Vasut wrote:
>>>>> Dear ?ukasz Da?ek,
>>>>>
>>>>>> On 26.09.2012 18:13, Marek Vasut wrote:
>>>>>>> Dear ?ukasz Da?ek,
>>>>>>>
>>>>>>>> On 26.09.2012 17:29, Marek Vasut wrote:
>>>>>>>>> Dear Lukasz Dalek,
>>>>>>>>>
>>>>>>>>>> Basic support of HP iPAQ h2200 palmtop. Support includes also USB
>>>>>>>>>> ethernet gadget.
>>>>>>>>> Two minor nits ... can you extend the patch description?
>>>>>>>>>
>>>>>>>>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
>>>>>>>>>> [...]
>>>>>>>>>> +h2200                        arm         pxa
>>>>>>>>>> +h2200_usbeth                 arm         pxa         h2200
>>>>>>>>>>
>>>>>>>>>>      -
>>>>>>>>> Can you not enable USB ethernet by default?
>>>>>>>>>
>>>>>>>>> [...]
>>>>>>>> I don't understand.
>>>>>>>>
>>>>>>>> make h2200_config creates config without usb ethernet
>>>>>>>> make h2200_usbeth_config creates config with usb ethernet
>>>>>>> Why not just make config with usb ethernet then?
>>>>>> Sorry but I don't understand. You've asked me that can I not
>>>>>> enable USB ethernet by default.
>>>>> I think you misunderstood. I was never against enabling the USB
>>>>> ethernet. I was against enabling it before the USB ethernet code is
>>>>> in, so it won't break bisectability.
>>>>>
>>>>> If I did really say so, I'm sorry for the confusion.
>>>> So you want from me to split h2200 patches? I mean to prepare 2 patches:
>>>> 1st one only adding support for device and 2nd one adding support for
>>>> ethernet?
>>> Oh, that would work nicely, good idea.
>> Ok, I will prepare them. But not sooner than tommorow.
> Take your time ... PXA won't run anywhere anyway. btw. you're polish? I might
> actually find you some old PXA device.

Yes, I'm polish. I've one: pxa25x.

?ukasz Da?ek

[U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

[Łukasz Dałek]

On 27.09.2012 02:06, Marek Vasut wrote:
> Dear ?ukasz Da?ek,
>
>> On 27.09.2012 01:58, Marek Vasut wrote:
>>> Dear ?ukasz Da?ek,
>>>
>>>> On 26.09.2012 17:31, Marek Vasut wrote:
>>>>> Dear Lukasz Dalek,
>>>>>
>>>>>> PXA25x gadget implements common function usb_disconnect().
>>>>>> This patch adds this function prototype into usb.h for boards using
>>>>>> it.
>>>>> [...]
>>>>>
>>>>>> +/*
>>>>>> + * This isn't host
>>>>>> + */
>>>>> The comment doesn't need to be multiline. It'd be cool if it was
>>>>> meaningful ... like "pxa25x can only do gadget mode, thus the following
>>>>> ... etc". Otherwise, we're basically there.
>>>> Ok
>>>>
>>>>> Can you repost the whole patchset please?
>>>> Whole? Including ethernet driver, pxa cpu detection etc...?
>>>> If so, I'll resend them.
>>> Yes, in correct order please. We're almost there now.
>>>
>>> btw. do you want to hack further on uboot? Maybe some PXA improvements
>>> cleanups etc?
>> Yes, but before I want to complete what I've started with h2200...
> You're basically there!

What do you mean saying that I am there?

>
> btw sorry if I sound a bit crazy, I've been pretty loaded recently so I might
> have forgotten what I have told you a few days ago ...

No problem.

?ukasz Da?ek

[U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

[Marek Vasut]

Dear ?ukasz Da?ek,

> On 27.09.2012 02:06, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> > 
> >> On 27.09.2012 01:58, Marek Vasut wrote:
> >>> Dear ?ukasz Da?ek,
> >>> 
> >>>> On 26.09.2012 17:31, Marek Vasut wrote:
> >>>>> Dear Lukasz Dalek,
> >>>>> 
> >>>>>> PXA25x gadget implements common function usb_disconnect().
> >>>>>> This patch adds this function prototype into usb.h for boards using
> >>>>>> it.
> >>>>> 
> >>>>> [...]
> >>>>> 
> >>>>>> +/*
> >>>>>> + * This isn't host
> >>>>>> + */
> >>>>> 
> >>>>> The comment doesn't need to be multiline. It'd be cool if it was
> >>>>> meaningful ... like "pxa25x can only do gadget mode, thus the
> >>>>> following ... etc". Otherwise, we're basically there.
> >>>> 
> >>>> Ok
> >>>> 
> >>>>> Can you repost the whole patchset please?
> >>>> 
> >>>> Whole? Including ethernet driver, pxa cpu detection etc...?
> >>>> If so, I'll resend them.
> >>> 
> >>> Yes, in correct order please. We're almost there now.
> >>> 
> >>> btw. do you want to hack further on uboot? Maybe some PXA improvements
> >>> cleanups etc?
> >> 
> >> Yes, but before I want to complete what I've started with h2200...
> > 
> > You're basically there!
> 
> What do you mean saying that I am there?

That you've walked most of the journey already, there's only the one small final 
step for you to do ...

> > btw sorry if I sound a bit crazy, I've been pretty loaded recently so I
> > might have forgotten what I have told you a few days ago ...
> 
> No problem.
> 
> ?ukasz Da?ek

Best regards,
Marek Vasut

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Marek Vasut]

Dear ?ukasz Da?ek,

> On 27.09.2012 02:07, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> > 
> >> On 27.09.2012 01:58, Marek Vasut wrote:
> >>> Dear ?ukasz Da?ek,
> >>> 
> >>>> On 27.09.2012 01:32, Marek Vasut wrote:
> >>>>> Dear ?ukasz Da?ek,
> >>>>> 
> >>>>>> On 26.09.2012 18:13, Marek Vasut wrote:
> >>>>>>> Dear ?ukasz Da?ek,
> >>>>>>> 
> >>>>>>>> On 26.09.2012 17:29, Marek Vasut wrote:
> >>>>>>>>> Dear Lukasz Dalek,
> >>>>>>>>> 
> >>>>>>>>>> Basic support of HP iPAQ h2200 palmtop. Support includes also
> >>>>>>>>>> USB ethernet gadget.
> >>>>>>>>> 
> >>>>>>>>> Two minor nits ... can you extend the patch description?
> >>>>>>>>> 
> >>>>>>>>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
> >>>>>>>>>> [...]
> >>>>>>>>>> +h2200                        arm         pxa
> >>>>>>>>>> +h2200_usbeth                 arm         pxa         h2200
> >>>>>>>>>> 
> >>>>>>>>>>      -
> >>>>>>>>> 
> >>>>>>>>> Can you not enable USB ethernet by default?
> >>>>>>>>> 
> >>>>>>>>> [...]
> >>>>>>>> 
> >>>>>>>> I don't understand.
> >>>>>>>> 
> >>>>>>>> make h2200_config creates config without usb ethernet
> >>>>>>>> make h2200_usbeth_config creates config with usb ethernet
> >>>>>>> 
> >>>>>>> Why not just make config with usb ethernet then?
> >>>>>> 
> >>>>>> Sorry but I don't understand. You've asked me that can I not
> >>>>>> enable USB ethernet by default.
> >>>>> 
> >>>>> I think you misunderstood. I was never against enabling the USB
> >>>>> ethernet. I was against enabling it before the USB ethernet code is
> >>>>> in, so it won't break bisectability.
> >>>>> 
> >>>>> If I did really say so, I'm sorry for the confusion.
> >>>> 
> >>>> So you want from me to split h2200 patches? I mean to prepare 2
> >>>> patches: 1st one only adding support for device and 2nd one adding
> >>>> support for ethernet?
> >>> 
> >>> Oh, that would work nicely, good idea.
> >> 
> >> Ok, I will prepare them. But not sooner than tommorow.
> > 
> > Take your time ... PXA won't run anywhere anyway. btw. you're polish? I
> > might actually find you some old PXA device.
> 
> Yes, I'm polish. I've one: pxa25x.

I have a pile of PXA boards here ... I think you can make do with the pxa255 for 
now and I'll see if I can find something for you.

> ?ukasz Da?ek

Best regards,
Marek Vasut

[U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

[Łukasz Dałek]

On 27.09.2012 02:30, Marek Vasut wrote:
> Dear ?ukasz Da?ek,
>
>> On 27.09.2012 02:06, Marek Vasut wrote:
>>> Dear ?ukasz Da?ek,
>>>
>>>> On 27.09.2012 01:58, Marek Vasut wrote:
>>>>> Dear ?ukasz Da?ek,
>>>>>
>>>>>> On 26.09.2012 17:31, Marek Vasut wrote:
>>>>>>> Dear Lukasz Dalek,
>>>>>>>
>>>>>>>> PXA25x gadget implements common function usb_disconnect().
>>>>>>>> This patch adds this function prototype into usb.h for boards using
>>>>>>>> it.
>>>>>>> [...]
>>>>>>>
>>>>>>>> +/*
>>>>>>>> + * This isn't host
>>>>>>>> + */
>>>>>>> The comment doesn't need to be multiline. It'd be cool if it was
>>>>>>> meaningful ... like "pxa25x can only do gadget mode, thus the
>>>>>>> following ... etc". Otherwise, we're basically there.
>>>>>> Ok
>>>>>>
>>>>>>> Can you repost the whole patchset please?
>>>>>> Whole? Including ethernet driver, pxa cpu detection etc...?
>>>>>> If so, I'll resend them.
>>>>> Yes, in correct order please. We're almost there now.
>>>>>
>>>>> btw. do you want to hack further on uboot? Maybe some PXA improvements
>>>>> cleanups etc?
>>>> Yes, but before I want to complete what I've started with h2200...
>>> You're basically there!
>> What do you mean saying that I am there?
> That you've walked most of the journey already, there's only the one small final
> step for you to do ...

Yes, indeed.

?ukasz Da?ek

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Łukasz Dałek]

On 27.09.2012 02:31, Marek Vasut wrote:
> Dear ?ukasz Da?ek,
>
>> On 27.09.2012 02:07, Marek Vasut wrote:
>>> Dear ?ukasz Da?ek,
>>>
>>>> On 27.09.2012 01:58, Marek Vasut wrote:
>>>>> Dear ?ukasz Da?ek,
>>>>>
>>>>>> On 27.09.2012 01:32, Marek Vasut wrote:
>>>>>>> Dear ?ukasz Da?ek,
>>>>>>>
>>>>>>>> On 26.09.2012 18:13, Marek Vasut wrote:
>>>>>>>>> Dear ?ukasz Da?ek,
>>>>>>>>>
>>>>>>>>>> On 26.09.2012 17:29, Marek Vasut wrote:
>>>>>>>>>>> Dear Lukasz Dalek,
>>>>>>>>>>>
>>>>>>>>>>>> Basic support of HP iPAQ h2200 palmtop. Support includes also
>>>>>>>>>>>> USB ethernet gadget.
>>>>>>>>>>> Two minor nits ... can you extend the patch description?
>>>>>>>>>>>
>>>>>>>>>>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
>>>>>>>>>>>> [...]
>>>>>>>>>>>> +h2200                        arm         pxa
>>>>>>>>>>>> +h2200_usbeth                 arm         pxa         h2200
>>>>>>>>>>>>
>>>>>>>>>>>>       -
>>>>>>>>>>> Can you not enable USB ethernet by default?
>>>>>>>>>>>
>>>>>>>>>>> [...]
>>>>>>>>>> I don't understand.
>>>>>>>>>>
>>>>>>>>>> make h2200_config creates config without usb ethernet
>>>>>>>>>> make h2200_usbeth_config creates config with usb ethernet
>>>>>>>>> Why not just make config with usb ethernet then?
>>>>>>>> Sorry but I don't understand. You've asked me that can I not
>>>>>>>> enable USB ethernet by default.
>>>>>>> I think you misunderstood. I was never against enabling the USB
>>>>>>> ethernet. I was against enabling it before the USB ethernet code is
>>>>>>> in, so it won't break bisectability.
>>>>>>>
>>>>>>> If I did really say so, I'm sorry for the confusion.
>>>>>> So you want from me to split h2200 patches? I mean to prepare 2
>>>>>> patches: 1st one only adding support for device and 2nd one adding
>>>>>> support for ethernet?
>>>>> Oh, that would work nicely, good idea.
>>>> Ok, I will prepare them. But not sooner than tommorow.
>>> Take your time ... PXA won't run anywhere anyway. btw. you're polish? I
>>> might actually find you some old PXA device.
>> Yes, I'm polish. I've one: pxa25x.
> I have a pile of PXA boards here ... I think you can make do with the pxa255 for
> now and I'll see if I can find something for you.

Ok, so for now we will focus on pxa255 :-)

?ukasz Da?ek

[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Marek Vasut]

Dear ?ukasz Da?ek,

> On 27.09.2012 02:31, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> > 
> >> On 27.09.2012 02:07, Marek Vasut wrote:
> >>> Dear ?ukasz Da?ek,
> >>> 
> >>>> On 27.09.2012 01:58, Marek Vasut wrote:
> >>>>> Dear ?ukasz Da?ek,
> >>>>> 
> >>>>>> On 27.09.2012 01:32, Marek Vasut wrote:
> >>>>>>> Dear ?ukasz Da?ek,
> >>>>>>> 
> >>>>>>>> On 26.09.2012 18:13, Marek Vasut wrote:
> >>>>>>>>> Dear ?ukasz Da?ek,
> >>>>>>>>> 
> >>>>>>>>>> On 26.09.2012 17:29, Marek Vasut wrote:
> >>>>>>>>>>> Dear Lukasz Dalek,
> >>>>>>>>>>> 
> >>>>>>>>>>>> Basic support of HP iPAQ h2200 palmtop. Support includes also
> >>>>>>>>>>>> USB ethernet gadget.
> >>>>>>>>>>> 
> >>>>>>>>>>> Two minor nits ... can you extend the patch description?
> >>>>>>>>>>> 
> >>>>>>>>>>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
> >>>>>>>>>>>> [...]
> >>>>>>>>>>>> +h2200                        arm         pxa
> >>>>>>>>>>>> +h2200_usbeth                 arm         pxa         h2200
> >>>>>>>>>>>> 
> >>>>>>>>>>>>       -
> >>>>>>>>>>> 
> >>>>>>>>>>> Can you not enable USB ethernet by default?
> >>>>>>>>>>> 
> >>>>>>>>>>> [...]
> >>>>>>>>>> 
> >>>>>>>>>> I don't understand.
> >>>>>>>>>> 
> >>>>>>>>>> make h2200_config creates config without usb ethernet
> >>>>>>>>>> make h2200_usbeth_config creates config with usb ethernet
> >>>>>>>>> 
> >>>>>>>>> Why not just make config with usb ethernet then?
> >>>>>>>> 
> >>>>>>>> Sorry but I don't understand. You've asked me that can I not
> >>>>>>>> enable USB ethernet by default.
> >>>>>>> 
> >>>>>>> I think you misunderstood. I was never against enabling the USB
> >>>>>>> ethernet. I was against enabling it before the USB ethernet code is
> >>>>>>> in, so it won't break bisectability.
> >>>>>>> 
> >>>>>>> If I did really say so, I'm sorry for the confusion.
> >>>>>> 
> >>>>>> So you want from me to split h2200 patches? I mean to prepare 2
> >>>>>> patches: 1st one only adding support for device and 2nd one adding
> >>>>>> support for ethernet?
> >>>>> 
> >>>>> Oh, that would work nicely, good idea.
> >>>> 
> >>>> Ok, I will prepare them. But not sooner than tommorow.
> >>> 
> >>> Take your time ... PXA won't run anywhere anyway. btw. you're polish? I
> >>> might actually find you some old PXA device.
> >> 
> >> Yes, I'm polish. I've one: pxa25x.
> > 
> > I have a pile of PXA boards here ... I think you can make do with the
> > pxa255 for now and I'll see if I can find something for you.
> 
> Ok, so for now we will focus on pxa255 :-)

I need to focus on whole 2xx series, I had 3xx support in the works, but 
Intel/Marvell did such a shitty job there on the bootrom I couldn't get the 
whole series work properly.

> ?ukasz Da?ek

Best regards,
Marek Vasut