From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 30 Sep 2012 15:22:53 +0200 Subject: [U-Boot] [PATCH 65/72] serial: ns16550: Rename serial.c to serial_ns16550.c In-Reply-To: <50680848.5060907@monstr.eu> References: <1348878687-14194-1-git-send-email-marex@denx.de> <1348955586-7109-66-git-send-email-marex@denx.de> <50680848.5060907@monstr.eu> Message-ID: <201209301522.54041.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Michal Simek, [...] > You are using two coding styles in this file. Won't surprise me if there were even more. > One has function return value on one line and then function name > and the second function return value on one line with function name. > Will be good to unify it to look the same in the whole file. Yes, but definitelly not as a part of unintrusive conversion patch. This file has so much legacy and look so crappy it needs proper fixing. Patch is welcome %^) > Thanks, > Michal Best regards, Marek Vasut