From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 1 Oct 2012 16:41:15 +0200
Subject: [U-Boot] [PATCH 39/71] serial: arm: Implement
	CONFIG_SERIAL_MULTI into altera_jtag serial driver
In-Reply-To: <50698D98.3060605@wytron.com.tw>
References: <1347837696-3192-1-git-send-email-marex@denx.de>
	<1347837696-3192-40-git-send-email-marex@denx.de>
	<50698D98.3060605@wytron.com.tw>
Message-ID: <201210011641.16103.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Thomas Chou,

> On 09/17/2012 07:21 AM, Marek Vasut wrote:
> > Implement support for CONFIG_SERIAL_MULTI into altera_jtag serial driver.
> > This driver was so far only usable directly, but this patch also adds
> > support for the multi method. This allows using more than one serial
> > driver alongside the altera_jtag driver. Also, add a weak implementation
> > of default_serial_console() returning this driver.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Tom Rini <trini@ti.com>
> > Cc: Thomas Chou <thomas@wytron.com.tw>
> > ---
> > 
> >   common/serial.c                   |    2 ++
> >   drivers/serial/altera_jtag_uart.c |   71
> >   +++++++++++++++++++++++++++++++++---- 2 files changed, 67
> >   insertions(+), 6 deletions(-)
> 
> Dear Marek,
> 
> Please include the following headers.
> 
> --- a/drivers/serial/altera_jtag_uart.c
> +++ b/drivers/serial/altera_jtag_uart.c
> @@ -25,6 +25,8 @@
>   #include <watchdog.h>
>   #include <asm/io.h>
>   #include <nios2-io.h>
> +#include <linux/compiler.h>
> +#include <serial.h>


Are you seeing any issues without them?

>   DECLARE_GLOBAL_DATA_PTR;
> 
> And the .name string is too long. >16
> 
> static struct serial_device altera_jtag_serial_drv = {
> 	.name	= "altera_jtag_serial",
> 
> Otherwise,
> Acked-by: Thomas Chou <thomas@wytron.com.tw>
> 
> Best regards,
> Thomas Chou
[...]