[U-Boot] [PATCH 31/71] serial: powerpc: Implement CONFIG_SERIAL_MULTI into amirix serial driver

Marek Vasut
2012-09-19T11:27:30Z

Dear Stefan Roese,

> On 09/17/2012 01:20 AM, Marek Vasut wrote:
> > Implement support for CONFIG_SERIAL_MULTI into amirix serial driver.
> > This driver was so far only usable directly, but this patch also adds
> > support for the multi method. This allows using more than one serial
> > driver alongside the amirix driver. Also, add a weak implementation
> > of default_serial_console() returning this driver.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Tom Rini <trini@ti.com>
> > Cc: Anatolij Gustschin <agust@denx.de>
> > Cc: Stefan Roese <sr@denx.de>
>
> This looks like a standard NS16550 implementation. Why not use the
> common driver then? Also, this board doesn't seem actively maintained. I
> cc'ed Frank Smith as author of this board port.
>
> Frank, is this board still in production? Or does it make sense to
> remove this board from mainline completely?

It's not the only one that reimplements NS16550. I didn't clean it up to avoid
breakage.

> Thanks,
> Stefan
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: office at denx.de

Best regards,
Marek Vasut