From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 1 Oct 2012 18:49:57 +0200
Subject: [U-Boot] [PATCH 65/72] serial: ns16550: Rename serial.c to
	serial_ns16550.c
In-Reply-To: <50680848.5060907@monstr.eu>
References: <1348878687-14194-1-git-send-email-marex@denx.de>
	<1348955586-7109-66-git-send-email-marex@denx.de>
	<50680848.5060907@monstr.eu>
Message-ID: <201210011849.58002.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Michal Simek,

[...]
> 
> Would it be better just use this structure?
> 
> #ifdef CONFIG_SYS_NS16550_COM1
>         [0] = (NS16550_t)CONFIG_SYS_NS16550_COM1,
> #endif
[...]

> 
> You are using two coding styles in this file.
> One has function return value on one line and then function name
> and the second function return value on one line with function name.
> Will be good to unify it to look the same in the whole file.

Yes, wholeheartedly agree! But (!) I don't want to clean up this file in this 
patchset.

> Thanks,
> Michal

Best regards,
Marek Vasut