From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 2 Oct 2012 12:07:05 +0200
Subject: [U-Boot] [PATCH 39/71] serial: arm: Implement
	CONFIG_SERIAL_MULTI into altera_jtag serial driver
In-Reply-To: <506A9DFD.4020902@wytron.com.tw>
References: <1347837696-3192-1-git-send-email-marex@denx.de>
	<201210011641.16103.marex@denx.de> <506A9DFD.4020902@wytron.com.tw>
Message-ID: <201210021207.05407.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Thomas Chou,

> On 10/01/2012 10:41 PM, Marek Vasut wrote:
> >> Please include the following headers.
> >> 
> >> --- a/drivers/serial/altera_jtag_uart.c
> >> +++ b/drivers/serial/altera_jtag_uart.c
> >> @@ -25,6 +25,8 @@
> >> 
> >>    #include <watchdog.h>
> >>    #include <asm/io.h>
> >>    #include <nios2-io.h>
> >> 
> >> +#include <linux/compiler.h>
> >> +#include <serial.h>
> > 
> > Are you seeing any issues without them?
> 
> Dear Marek,
> 
> The serial.h defines the struct serial_device.
> And the linux/compiler.h defines the __weak attribute.
> Without them, it won't compile.
> 
> I have pulled your latest dm-serial-1 branch, compiled and tested
> altera_uart and altera_jtag_uart on nios2 board. They work without problem.
> 
> There is only minor size change.
> 
> Before..
> Configuring for nios2-generic board...
>     text	   data	    bss	    dec	    hex	filename
>   134782	   3206	  23173	 161161	  27589	/home/thomas/tmp/u-boot/u-boot
> 
> After..
> Configuring for nios2-generic board...
>     text	   data	    bss	    dec	    hex	filename
>   135450	   3254	  23181	 161885	  2785d	/home/thomas/tmp/u-boot/u-boot
> 
> Thank you very much.

Perfect! Thank YOU!

> Best regards
> Thomas Chou

Best regards,
Marek Vasut