From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] ARM: prevent misaligned array inits
Date: Tue, 2 Oct 2012 23:20:00 +0200 [thread overview]
Message-ID: <20121002232000.15c1af10@lilith> (raw)
In-Reply-To: <506B495D.2030306@wwwdotorg.org>
Hi Stephen,
On Tue, 02 Oct 2012 14:06:53 -0600, Stephen Warren
<swarren@wwwdotorg.org> wrote:
> > +c) Relax the -munified-access rule globally. This will prevent native
>
> I assume that's meant to say -munaligned-access?
> > + until the target gets compiled with m-unaligned-access.
>
> s/m-/-m/
> > +d) Relax the -munified-access rule only for for files susceptible to
>
> I assume that's meant to say -munaligned-access?
Thanks for spotting these. Fixed in next round.
> > + the local initialized array issue. This minimizes the quantity of
> > + code which can hide unwanted misaligned accesses.
> > +
> > +Considering the rarity of actual occurrences (as of this writing, 5
> > +files out of 7840 in U-Boot, or .3%, contain an initialized local char
> > +array which cannot actually be replaced with a const char*), detection
> > +if the issue in patches should not be asked from contributors.
>
> I assume therefore that option (d) was chosen. Perhaps state this
> explicitly?
Thanks for pointing out the ambiguity: indeed option d) is the one
chosen. Made explicit in next round.
Thanks again!
Amicalement,
--
Albert.
next prev parent reply other threads:[~2012-10-02 21:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 18:46 [U-Boot] [RFC] ARM: prevent misaligned array inits Albert ARIBAUD
2012-10-02 19:13 ` Joakim Tjernlund
2012-10-02 20:05 ` Albert ARIBAUD
2012-10-03 8:22 ` Joakim Tjernlund
2012-10-02 20:06 ` Stephen Warren
2012-10-02 21:20 ` Albert ARIBAUD [this message]
2012-10-02 21:42 ` Måns Rullgård
2012-10-03 7:29 ` Mark Marshall
2012-10-04 20:22 ` Albert ARIBAUD
2012-10-04 12:02 ` Thierry Reding
2012-10-04 19:10 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002232000.15c1af10@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox