From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Wed, 3 Oct 2012 03:04:22 +0200
Subject: [U-Boot] [PATCH v5 3/3] h2200: Add USB CDC ethernet support
In-Reply-To: <506B8733.3000609@gmail.com>
References: <1349218267-23809-1-git-send-email-luk0104@gmail.com>
	<201210030225.02968.marex@denx.de> <506B8733.3000609@gmail.com>
Message-ID: <201210030304.22575.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear ?ukasz Da?ek,

> On 03.10.2012 02:25, Marek Vasut wrote:
> > Dear ?ukasz Da?ek,
> > 
> >> On 03.10.2012 02:18, Marek Vasut wrote:
> >>> Dear ?ukasz Da?ek,
> >>> 
> >>>> On 03.10.2012 02:06, Marek Vasut wrote:
> >>>>> Dear Lukasz Dalek,
> >>>>> 
> >>>>>> Add support for ethernet over USB which can be used for e.g. booting
> >>>>>> process. It works with tftp and dhcp clients code.
> >>>>>> 
> >>>>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
> >>>>>> ---
> >>>>>> 
> >>>>>> Changes for v5:
> >>>>>> 	- Surrendered #include<usb.h>    with CONFIGs
> >>>>>> 	
> >>>>>>     board/h2200/h2200.c     |   17 +++++++++++++++++
> >>>>>>     boards.cfg              |    1 +
> >>>>>>     include/configs/h2200.h |   27 +++++++++++++++++++++++++++
> >>>>>>     3 files changed, 45 insertions(+), 0 deletions(-)
> >>>>> 
> >>>>> [...]
> >>>>> 
> >>>>>> diff --git a/boards.cfg b/boards.cfg
> >>>>>> index ab10938..a03a469 100644
> >>>>>> --- a/boards.cfg
> >>>>>> +++ b/boards.cfg
> >>>>>> @@ -283,6 +283,7 @@ pdnb3                        arm         ixp
> >>>>>> pdnb3               prodriv scpu                         arm
> >>>>>> ixp
> >>>>>> 
> >>>>>>          pdnb3               prodrive       -           pdnb3:SCPU
> >>>>>>          balloon3
> >>>>>>          
> >>>>>>                      arm         pxa
> >>>>>>     
> >>>>>>     h2200                        arm         pxa
> >>>>>> 
> >>>>>> +h2200_usbeth                 arm         pxa         h2200
> >>>>>> 
> >>>>>>    -
> >>>>> 
> >>>>> I told you to enable the USB ethernet by default, so why do you add
> >>>>> this board?
> >>>> 
> >>>> I don't understand.
> >>>> We agreed to split h2200 support into two parts. First one adding
> >>>> basic support for device, second one adding support for usb ethernet
> >>>> for h2200.
> >>> 
> >>> Yes, but I fail to understand why you need TWO board entries for that.
> >>> Adding the USB ethernet support is just a feature, you don't need
> >>> additional board entry for that ... so what is the idea behind adding
> >>> it?
> >> 
> >> Because easier is to type make h2200_usbeth_config than modifiy config.
> > 
> > Why don't you enable the USB ethernet by default for "h2200" target then?
> > 
> > Best regards,
> > Marek Vasut
> 
> I will enable. This two entries really look weird.

Ok, so we're clear there'll be one entry with ethernet enabled called "h2200", 
yes?

Best regards,
Marek Vasut