From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tpm: Remove the LPC TPM driver
Date: Thu, 4 Oct 2012 02:25:22 +0200 [thread overview]
Message-ID: <201210040225.22729.marex@denx.de> (raw)
In-Reply-To: <CAPnjgZ3_TbcK0t2_q_8oUzrxA3YOauhWu=rpCs+RyQWSt=HSkw@mail.gmail.com>
Dear Simon Glass,
> Hi Marek,
>
> On Sun, Sep 30, 2012 at 4:24 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Simon Glass,
> >
> >> Hi Marek,
> >>
> >> On Sun, Sep 30, 2012 at 11:09 AM, Marek Vasut <marex@denx.de> wrote:
> >> > Dear Vadim Bendebury,
> >> >
> >> >> On Sun, Sep 30, 2012 at 10:36 AM, Marek Vasut <marex@denx.de> wrote:
> >> >> > The driver is not used anywhere. It is a dead code and it seems to
> >> >> > be falling apart slowly due to bitrot. Remove this driver.
> >> >>
> >> >> This driver is used in several chromeOS devices which have not quite
> >> >> made it upstream yet. Why does it seem falling apart?
> >> >
> >> > Noone tested it every since, it seems unmaintained to me. This it is
> >> > only logical to drop it if there are no users. Will the chromium
> >> > devices ever make it upstream?
> >>
> >> The TPM code is used by coreboot and Tegra Seaboard, both of which are
> >> upstream. We are working hard on a third :-)
> >
> > Where do you enable it on either board? I see this:
> OK I see, it seems we are missing some patches upstream. I will
> prepare a patch to enable for chromebook-x86.
Ah ok, thanks!
> > $ git grep CONFIG_GENERIC_LPC_TPM
> > Makefile:LIBS-$(CONFIG_GENERIC_LPC_TPM) += drivers/tpm/libtpm.o
> > README: CONFIG_GENERIC_LPC_TPM
> > drivers/tpm/Makefile:COBJS-$(CONFIG_GENERIC_LPC_TPM) = generic_lpc_tpm.o
> >
> >> If there is a build problem, please can you let us know?
> >
> > I don't know, it's not enabled anywhere. It's just code that is there but
> > noone uses it.
>
> I recall a discussion about it, but perhaps nothing happened after
> that. Very much don't want this driver removed, as we are working on
> upstreaming another board which uses it.
Maybe you can bribe me with a chromebook* so I won't push for removal of this
code** ;-)
* - of course with the chip
** - of course I'm joking!
> Regards,
> Simon
>
> >> Regards,
> >> Simon
> >>
> >> >> cheers,
> >> >> /vb
> >> >>
> >> >> > Signed-off-by: Marek Vasut <marex@denx.de>
> >> >> > Cc: Vadim Bendebury <vbendeb@chromium.org>
> >> >> > Cc: Tom Rini <trini@ti.com>
> >> >> > ---
Best regards,
Marek Vasut
prev parent reply other threads:[~2012-10-04 0:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 17:36 [U-Boot] [PATCH] tpm: Remove the LPC TPM driver Marek Vasut
2012-09-30 18:07 ` Vadim Bendebury
2012-09-30 18:09 ` Marek Vasut
2012-09-30 22:30 ` Simon Glass
2012-09-30 23:24 ` Marek Vasut
2012-10-03 19:21 ` Simon Glass
2012-10-04 0:25 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210040225.22729.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox