public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] i2c: sh: Remove irq_wait function
@ 2012-10-03  2:49 Nobuhiro Iwamatsu
  2012-10-04  6:25 ` hs at denx.de
  0 siblings, 1 reply; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2012-10-03  2:49 UTC (permalink / raw)
  To: u-boot

irq_wait function is not referred to from anywhere.

Reported-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>

---
 drivers/i2c/sh_i2c.c |   16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/i2c/sh_i2c.c b/drivers/i2c/sh_i2c.c
index fd8cb92..3147123 100644
--- a/drivers/i2c/sh_i2c.c
+++ b/drivers/i2c/sh_i2c.c
@@ -52,22 +52,6 @@ static u8 iccl, icch;
 
 #define IRQ_WAIT 1000
 
-static void irq_wait(struct sh_i2c *base)
-{
-	int i;
-	u8 status;
-
-	for (i = 0 ; i < IRQ_WAIT ; i++) {
-		status = readb(&base->icsr);
-		if (SH_IC_WAIT & status)
-			break;
-
-		udelay(10);
-	}
-
-	writeb(status & ~SH_IC_WAIT, &base->icsr);
-}
-
 static void irq_dte(struct sh_i2c *base)
 {
 	int i;
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] i2c: sh: Remove irq_wait function
  2012-10-03  2:49 [U-Boot] [PATCH] i2c: sh: Remove irq_wait function Nobuhiro Iwamatsu
@ 2012-10-04  6:25 ` hs at denx.de
  2012-10-04  7:41   ` Anatolij Gustschin
  0 siblings, 1 reply; 3+ messages in thread
From: hs at denx.de @ 2012-10-04  6:25 UTC (permalink / raw)
  To: u-boot

Hello Nobuhiro,

Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> wrote:
> irq_wait function is not referred to from anywhere.
>
> Reported-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>
> ---
>  drivers/i2c/sh_i2c.c |   16 ----------------
>  1 file changed, 16 deletions(-)

Good catch!

Hmm.. for some reason, I could not find this patch in patchwork...
Did you or Albert changed the state from it in patchwork?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] i2c: sh: Remove irq_wait function
  2012-10-04  6:25 ` hs at denx.de
@ 2012-10-04  7:41   ` Anatolij Gustschin
  0 siblings, 0 replies; 3+ messages in thread
From: Anatolij Gustschin @ 2012-10-04  7:41 UTC (permalink / raw)
  To: u-boot

Hi Heiko,

On Thu, 04 Oct 2012 08:25:55 +0200
hs at denx.de wrote:

> Hello Nobuhiro,
> 
> Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> wrote:
> > irq_wait function is not referred to from anywhere.
> >
> > Reported-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> >
> > ---
> >  drivers/i2c/sh_i2c.c |   16 ----------------
> >  1 file changed, 16 deletions(-)
> 
> Good catch!
> 
> Hmm.. for some reason, I could not find this patch in patchwork...
> Did you or Albert changed the state from it in patchwork?

this patch is already in u-boot-arm.git tree and the state on patchwork
is accepted. Albert applied it directly, it seems.

Thanks,
Anatolij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-10-04  7:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-03  2:49 [U-Boot] [PATCH] i2c: sh: Remove irq_wait function Nobuhiro Iwamatsu
2012-10-04  6:25 ` hs at denx.de
2012-10-04  7:41   ` Anatolij Gustschin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox