From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ARM: increase lmb stack space reservation to 4KB
Date: Thu, 4 Oct 2012 10:36:24 +0200 [thread overview]
Message-ID: <20121004103624.40d97968@lilith> (raw)
In-Reply-To: <1340891651-17618-2-git-send-email-robherring2@gmail.com>
Hi Rob,
On Thu, 28 Jun 2012 08:54:11 -0500, Rob Herring <robherring2@gmail.com>
wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> The bootm initrd image copy to ram can collide with the stack in cases
> where the print buffer size is large (i.e. 1K). The result is intermittent
> initrd decompression errors depending on the initrd size MOD 4KB since
> the initrd start address is 4KB aligned.
>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> ---
> arch/arm/lib/bootm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
> index 599547d..999f201 100644
> --- a/arch/arm/lib/bootm.c
> +++ b/arch/arm/lib/bootm.c
> @@ -69,8 +69,8 @@ void arch_lmb_reserve(struct lmb *lmb)
> sp = get_sp();
> debug("## Current stack ends at 0x%08lx ", sp);
>
> - /* adjust sp by 1K to be safe */
> - sp -= 1024;
> + /* adjust sp by 4K to be safe */
> + sp -= 4096;
> lmb_reserve(lmb, sp,
> gd->bd->bi_dram[0].start + gd->bd->bi_dram[0].size - sp);
> }
Applied to u-boot-arm/master, thanks!
Amicalement,
--
Albert.
prev parent reply other threads:[~2012-10-04 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 13:54 [U-Boot] [PATCH 2/2] ARM: increase lmb stack space reservation to 4KB Rob Herring
2012-08-17 15:41 ` Rob Herring
2012-10-04 8:36 ` Albert ARIBAUD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004103624.40d97968@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox