public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] armv7 cpu_init_crit: Simplify code
Date: Thu, 4 Oct 2012 11:19:38 +0200	[thread overview]
Message-ID: <20121004111938.17d1dfc3@lilith> (raw)
In-Reply-To: <2025492723.2284420.1344636316297.JavaMail.root@advansee.com>

Hi Beno?t,

On Sat, 11 Aug 2012 00:05:16 +0200 (CEST), Beno?t Th?baudeau
<benoit.thebaudeau@advansee.com> wrote:

> We don't need to return to cpu_init_crit after calling lowlevel_init, so
> lowlevel_init can directly return to the caller of cpu_init_crit.
> 
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> ---
>  .../arch/arm/cpu/armv7/start.S                     |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git u-boot-4d3c95f.orig/arch/arm/cpu/armv7/start.S u-boot-4d3c95f/arch/arm/cpu/armv7/start.S
> index aee27fd..e8e533e 100644
> --- u-boot-4d3c95f.orig/arch/arm/cpu/armv7/start.S
> +++ u-boot-4d3c95f/arch/arm/cpu/armv7/start.S
> @@ -357,10 +357,7 @@ ENTRY(cpu_init_crit)
>  	 * basic memory. Go here to bump up clock rate and handle
>  	 * wake up conditions.
>  	 */
> -	mov	ip, lr			@ persevere link reg across call
> -	bl	lowlevel_init		@ go setup pll,mux,memory
> -	mov	lr, ip			@ restore link
> -	mov	pc, lr			@ back to my caller
> +	b	lowlevel_init		@ go setup pll,mux,memory
>  ENDPROC(cpu_init_crit)
>  #endif
>  
> 

Applied to u-boot-arm/master, thanks!

Amicalement,
-- 
Albert.

      reply	other threads:[~2012-10-04  9:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-10 22:05 [U-Boot] [PATCH] armv7 cpu_init_crit: Simplify code Benoît Thébaudeau
2012-10-04  9:19 ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121004111938.17d1dfc3@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox