* [U-Boot] [PATCH] armv7 cpu_init_crit: Simplify code
@ 2012-08-10 22:05 Benoît Thébaudeau
2012-10-04 9:19 ` Albert ARIBAUD
0 siblings, 1 reply; 2+ messages in thread
From: Benoît Thébaudeau @ 2012-08-10 22:05 UTC (permalink / raw)
To: u-boot
We don't need to return to cpu_init_crit after calling lowlevel_init, so
lowlevel_init can directly return to the caller of cpu_init_crit.
Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
Cc: Albert Aribaud <albert.u.boot@aribaud.net>
---
.../arch/arm/cpu/armv7/start.S | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git u-boot-4d3c95f.orig/arch/arm/cpu/armv7/start.S u-boot-4d3c95f/arch/arm/cpu/armv7/start.S
index aee27fd..e8e533e 100644
--- u-boot-4d3c95f.orig/arch/arm/cpu/armv7/start.S
+++ u-boot-4d3c95f/arch/arm/cpu/armv7/start.S
@@ -357,10 +357,7 @@ ENTRY(cpu_init_crit)
* basic memory. Go here to bump up clock rate and handle
* wake up conditions.
*/
- mov ip, lr @ persevere link reg across call
- bl lowlevel_init @ go setup pll,mux,memory
- mov lr, ip @ restore link
- mov pc, lr @ back to my caller
+ b lowlevel_init @ go setup pll,mux,memory
ENDPROC(cpu_init_crit)
#endif
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] armv7 cpu_init_crit: Simplify code
2012-08-10 22:05 [U-Boot] [PATCH] armv7 cpu_init_crit: Simplify code Benoît Thébaudeau
@ 2012-10-04 9:19 ` Albert ARIBAUD
0 siblings, 0 replies; 2+ messages in thread
From: Albert ARIBAUD @ 2012-10-04 9:19 UTC (permalink / raw)
To: u-boot
Hi Beno?t,
On Sat, 11 Aug 2012 00:05:16 +0200 (CEST), Beno?t Th?baudeau
<benoit.thebaudeau@advansee.com> wrote:
> We don't need to return to cpu_init_crit after calling lowlevel_init, so
> lowlevel_init can directly return to the caller of cpu_init_crit.
>
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> ---
> .../arch/arm/cpu/armv7/start.S | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git u-boot-4d3c95f.orig/arch/arm/cpu/armv7/start.S u-boot-4d3c95f/arch/arm/cpu/armv7/start.S
> index aee27fd..e8e533e 100644
> --- u-boot-4d3c95f.orig/arch/arm/cpu/armv7/start.S
> +++ u-boot-4d3c95f/arch/arm/cpu/armv7/start.S
> @@ -357,10 +357,7 @@ ENTRY(cpu_init_crit)
> * basic memory. Go here to bump up clock rate and handle
> * wake up conditions.
> */
> - mov ip, lr @ persevere link reg across call
> - bl lowlevel_init @ go setup pll,mux,memory
> - mov lr, ip @ restore link
> - mov pc, lr @ back to my caller
> + b lowlevel_init @ go setup pll,mux,memory
> ENDPROC(cpu_init_crit)
> #endif
>
>
Applied to u-boot-arm/master, thanks!
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-04 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-10 22:05 [U-Boot] [PATCH] armv7 cpu_init_crit: Simplify code Benoît Thébaudeau
2012-10-04 9:19 ` Albert ARIBAUD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox