From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sun, 7 Oct 2012 20:21:58 +0200
Subject: [U-Boot] [PATCH 07/10] move CPC45 ide_led to the same file as
	other IDE hooks
In-Reply-To: <1349625374-12391-8-git-send-email-morpheus.ibis@gmail.com>
References: <1349625374-12391-1-git-send-email-morpheus.ibis@gmail.com>
	<1349625374-12391-8-git-send-email-morpheus.ibis@gmail.com>
Message-ID: <201210072021.58840.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Pavel Herrmann,

> Keep all IDE-related hooks and overrides in a single file, to avoid
> confusion.
> 
> Signed-off-by: Pavel Herrmann <morpheus.ibis@gmail.com>
> ---
[...]

> +
> +void ide_led(uchar led, uchar status)
> +{
> +	u_char	val;
> +	/* We have one PCMCIA slot and use LED H4 for the IDE Interface */
> +	val = readb(BCSR_BASE + 0x04);
> +	if (status) {				/* led on */
> +		val |= B_CTRL_LED0;
> +	} else {
> +		val &= ~B_CTRL_LED0;
> +	}

Remove these {} for conditions with single line expression

> +	writeb(val, BCSR_BASE + 0x04);
> +}
> +

Best regards,
Marek Vasut