From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/2] FAT: check for partition 0 not 1 for whole-disk fs
Date: Mon, 8 Oct 2012 11:47:25 -0700 [thread overview]
Message-ID: <20121008184725.GC18891@bill-the-cat> (raw)
In-Reply-To: <1349479060-3211-1-git-send-email-swarren@wwwdotorg.org>
On Fri, Oct 05, 2012 at 01:17:39PM -0000, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The recent switch to use get_device_and_partition() from do_fat_ls()
> broke the ability to access a FAT filesystem directly on a whole device;
> FAT only works within a partition on a device.
>
> This change makes e.g. "fatls mmc 0:0" work; explicitly requesting
> partition ID 0 is something that get_device_and_partition() fully
> supports. However, fat_register_device() expects partition ID 1 to be
> used in the full-disk case; partition ID 1 was previously implicitly
> specified when the user didn't actually specify a partition ID. Update
> fat_register_device() to expect the correct ID.
>
> This change does imply that if a user explicitly executes "fatls mmc 0:1"
> then this will fail, and may be a change in behaviour.
>
> Note that this still prevents "fatls mmc 0:auto" from working. The next
> patch will fix that.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> ---
> Tom, this series is really a bug-fix and should go in before the 9-long
> series I posted earlier today. I'll need to rebase that other series on
> top of this and repost, once any comments are addressed.
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121008/333d45e1/attachment.pgp>
prev parent reply other threads:[~2012-10-08 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 23:17 [U-Boot] [PATCH 1/2] FAT: check for partition 0 not 1 for whole-disk fs Stephen Warren
2012-10-05 23:17 ` [U-Boot] [PATCH 2/2] disk: part_dos: don't claim whole-disk FAT filesystems Stephen Warren
2012-10-08 18:47 ` [U-Boot] [U-Boot, " Tom Rini
2012-10-05 23:27 ` [U-Boot] [PATCH 1/2] FAT: check for partition 0 not 1 for whole-disk fs Tom Rini
2012-10-05 23:36 ` Stephen Warren
2012-10-05 23:39 ` Tom Rini
2012-10-05 23:46 ` Stephen Warren
2012-10-08 18:47 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008184725.GC18891@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox