From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] h2200: Make use of default_serial_console
Date: Thu, 11 Oct 2012 19:59:11 +0200 [thread overview]
Message-ID: <20121011195911.37ad0c83@lilith> (raw)
In-Reply-To: <20121011194008.64816b84@lilith>
On Thu, 11 Oct 2012 19:40:08 +0200, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:
> Hi Lukasz,
>
> On Wed, 10 Oct 2012 02:09:59 +0200, Lukasz Dalek <luk0104@gmail.com>
> wrote:
>
> > Define CONFIG_CONS_INDEX to use ffuart as default console and fix
> > compilation error related to undefined CONFIG_CONS_INDEX.
> >
> > Signed-off-by: Lukasz Dalek <luk0104@gmail.com>
> > ---
> > include/configs/h2200.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/configs/h2200.h b/include/configs/h2200.h
> > index de5299b..ef14dd3 100644
> > --- a/include/configs/h2200.h
> > +++ b/include/configs/h2200.h
> > @@ -124,6 +124,7 @@
> >
> > #define CONFIG_PXA_SERIAL
> > #define CONFIG_FFUART
> > +#define CONFIG_CONS_INDEX 3
> >
> > #define CONFIG_BAUDRATE 115200
> > #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 38400, 115200 }
>
> This is actually a second patch, applying only above the first h2200
> patch, which was removed from next because it did not build. If I
> accepted that second patch, then I'd have to accept the first one,
> which is precisely what I did not do, because I did not want the
> first commit introducing h2200 to be non-buildable. :(
>
> Therefore I'd prefer that you squash both patches "h2200: Add support
> for iPAQ h2200" and "h2200: Make use of default_serial_console"
> together and post the result as "[PATCH V2] h2200: Add support for iPAQ
> h2200" with adequate version history, so that the commit in U-Boot which
> introduces h2200 actually builds successfully.
... plus you can add the missing MAINTAINERS entry. :)
Amicalement,
--
Albert.
next prev parent reply other threads:[~2012-10-11 17:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 15:34 [U-Boot] Pull request: u-boot-arm/next into u-boot/next Albert ARIBAUD
2012-10-09 21:45 ` Tom Rini
2012-10-09 22:27 ` [U-Boot] h2200 fails to build on current u-boot/next (was: Pull request: u-boot-arm/next into u-boot/next) Albert ARIBAUD
2012-10-09 23:44 ` [U-Boot] h2200 fails to build on current u-boot/next Łukasz Dałek
2012-10-10 0:09 ` [U-Boot] [PATCH] h2200: Make use of default_serial_console Lukasz Dalek
2012-10-10 1:21 ` Marek Vasut
2012-10-11 17:40 ` Albert ARIBAUD
2012-10-11 17:59 ` Albert ARIBAUD [this message]
2012-10-15 17:46 ` [U-Boot] [PATCH v6] h2200: Add support for iPAQ h2200 palmtop Lukasz Dalek
2012-10-09 22:24 ` [U-Boot] Pull request: u-boot-arm/next into u-boot/next Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011195911.37ad0c83@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox