[U-Boot] [PATCH] h2200: Make use of default_serial_console

Albert ARIBAUD
2012-10-11T17:59:11Z

On Thu, 11 Oct 2012 19:40:08 +0200, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:

> Hi Lukasz,
>
> On Wed, 10 Oct 2012 02:09:59 +0200, Lukasz Dalek <luk0104@gmail.com>
> wrote:
>
> > Define CONFIG_CONS_INDEX to use ffuart as default console and fix
> > compilation error related to undefined CONFIG_CONS_INDEX.
> >
> > Signed-off-by: Lukasz Dalek <luk0104@gmail.com>
> > ---
> > include/configs/h2200.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/configs/h2200.h b/include/configs/h2200.h
> > index de5299b..ef14dd3 100644
> > --- a/include/configs/h2200.h
> > +++ b/include/configs/h2200.h
> > @@ -124,6 +124,7 @@
> >
> > #define CONFIG_PXA_SERIAL
> > #define CONFIG_FFUART
> > +#define CONFIG_CONS_INDEX 3
> >
> > #define CONFIG_BAUDRATE 115200
> > #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 38400, 115200 }
>
> This is actually a second patch, applying only above the first h2200
> patch, which was removed from next because it did not build. If I
> accepted that second patch, then I'd have to accept the first one,
> which is precisely what I did not do, because I did not want the
> first commit introducing h2200 to be non-buildable. :(
>
> Therefore I'd prefer that you squash both patches "h2200: Add support
> for iPAQ h2200" and "h2200: Make use of default_serial_console"
> together and post the result as "[PATCH V2] h2200: Add support for iPAQ
> h2200" with adequate version history, so that the commit in U-Boot which
> introduces h2200 actually builds successfully.

... plus you can add the missing MAINTAINERS entry. :)

Amicalement,
--
Albert.