From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM926: Add mb to the cache invalidate/flush
Date: Thu, 11 Oct 2012 22:01:32 +0200 [thread overview]
Message-ID: <20121011220132.0dfc1b48@lilith> (raw)
In-Reply-To: <95DC1AA8EC908B48939B72CF375AA5E3053318DC84@alice.at.omicron.at>
Hi Mark,
Thanks for your example.
> My understanding of gcc is that global memory accesses are meant to
> stay on the correct side of an asm with a "memory" clobber. The gcc
> manual states that if you use a memory clobber, the asm should also
> be volatile.
Not exactly. It states that you need to add volatile if you cannot tell
where in memory your instruction will write; if you can tell (by
specifying "m" as an output of the asm) then volatile is not
needed -- simply because the compiler can tell where in memory the
write will happen, and will thus not eliminate the asm statement as
long as the destination memory is not optimized out.
> I'm not sure if adding the memory clobber is enough, but it's certainly a help.
memory clobber can help, but I don't think it helps, and I know it does
not help enough, in the patch's case.
> Regards,
>
> Mark M.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2012-10-11 20:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 22:44 [U-Boot] [PATCH] ARM926: Add mb to the cache invalidate/flush Marek Vasut
2012-10-11 5:31 ` Albert ARIBAUD
2012-10-11 12:09 ` Marek Vasut
2012-10-11 18:03 ` Scott Wood
2012-10-11 20:03 ` Albert ARIBAUD
2012-10-11 20:21 ` Scott Wood
2012-10-11 23:37 ` Albert ARIBAUD
2012-10-12 0:03 ` Scott Wood
[not found] ` <95DC1AA8EC908B48939B72CF375AA5E3053318DC84@alice.at.omicron.at>
2012-10-11 20:01 ` Albert ARIBAUD [this message]
2012-10-11 21:09 ` Scott Wood
2012-10-11 22:44 ` Albert ARIBAUD
2012-10-13 9:56 ` Albert ARIBAUD
-- strict thread matches above, loose matches on Subject: below --
2012-08-29 13:50 Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011220132.0dfc1b48@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox