From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Fri, 12 Oct 2012 13:08:18 +0200 Subject: [U-Boot] [PATCH] FEC: Rework RX buffer init In-Reply-To: <1349822613-26137-1-git-send-email-marex@denx.de> References: <1349822613-26137-1-git-send-email-marex@denx.de> Message-ID: <20121012130818.09c035eb@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, On Wed, 10 Oct 2012 00:43:33 +0200, Marek Vasut wrote: > Rework the RX buffer init so that it's easier to understand. > Firstly, allocate the whole RX buffer as one large continuous > piece of memory. Also, drop all these writel() accessors used > on the FEC RX DMA descriptor, since it's all flat bogus. I'd like this commit message to be more usefully descriptive than "all flat bogus". What exactly is bogus in it? > Finally, this makes recoverable stalls of the FEC on i.MX28 > disappear completely. Are both the single allocation change and the writel() change needed for this? Amicalement, -- Albert.