From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 09/16] arm: Add control over cachability of memory regions
Date: Sat, 13 Oct 2012 13:21:36 +0200 [thread overview]
Message-ID: <20121013132136.28228eb9@lilith> (raw)
In-Reply-To: <1349732556-30700-10-git-send-email-sjg@chromium.org>
Hi Simon,
No comment on the patch itself except for one general question:
On Mon, 8 Oct 2012 14:42:29 -0700, Simon Glass <sjg@chromium.org>
wrote:
> Add support for adjusting the cachability of an L1 section by updating
> the MMU. The mmu_set_region_dcache() function allows drivers to make
> these changes after the MMU is set up.
Can you just reformulate this a bit? "L1" is not necessary about cache
(there can be for instance TCM, frequently (if not correctly) called L1
RAM where I work, for the obvious reason that they are accessed at the
same level/layer as the L1 cache. Also, off, writethrough and copyback
are "cache behaviors" in ARM parlance, not "cachability". Therefore I
would prefer something like
"Add support for adjusting the L1 cache behavior by updating the MMU
configuration. The mmu_set_region_dcache_behavior() function allows
drivers to make these changes after the MMU is set up."
(note the suggestion includes slightly renaming the function)
Thanks in advance for considering this suggestion.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2012-10-13 11:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 21:42 [U-Boot] [PATCH v5 0/16] tegra: Add display driver and LCD support for Seaboard Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 01/16] tegra: Use const for pinmux_config_pingroup/table() Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 02/16] tegra: Add display support to funcmux Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 03/16] tegra: fdt: Add pwm binding and node Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 04/16] tegra: fdt: Add LCD definitions for Tegra Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 05/16] tegra: Add support for PWM Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 06/16] tegra: Add SOC support for display/lcd Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 07/16] tegra: Add LCD driver Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 08/16] tegra: Add LCD support to Nvidia boards Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 09/16] arm: Add control over cachability of memory regions Simon Glass
2012-10-09 10:23 ` R Sricharan
2012-10-13 11:21 ` Albert ARIBAUD [this message]
2012-10-17 22:21 ` Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 10/16] lcd: Add CONFIG_LCD_ALIGNMENT to select frame buffer alignment Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 11/16] lcd: Add support for flushing LCD fb from dcache after update Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 12/16] tegra: Align LCD frame buffer to section boundary Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 13/16] tegra: Support control of cache settings for LCD Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 14/16] tegra: fdt: Add LCD definitions for Seaboard Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 15/16] lcd: Add CONFIG_CONSOLE_SCROLL_LINES option to speed console Simon Glass
2012-10-08 21:42 ` [U-Boot] [PATCH v5 16/16] tegra: Enable display/lcd support on Seaboard Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121013132136.28228eb9@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox