From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 13 Oct 2012 14:23:01 +0200 Subject: [U-Boot] [PATCH v5 2/2] qi_lb60: add software usbboot support In-Reply-To: References: <1350007160-16383-1-git-send-email-xiangfu@openmobilefree.net> <201210130501.28092.marex@denx.de> Message-ID: <201210131423.02139.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear xiangfu liu, > Hi Marek > > This file was wrote by Ingenic people. I don't have time to convert it to > C(I am not very good in mips assembler). the .S file implement basic USB > stack. We already do have an USB stack. > this C code ( > http://projects.qi-hardware.com/index.php/p/xburst-tools/source/tree/master > /xbboot) implement the host app. the host app source code even clear then > the original Ingenic document. so feel free to send patch. Sorry, but it is my duty as a USB custodian to NAK patches which try to circumvent the constant effort to keep the code clean. Obviously, implementing yet another USB stack is violation of this. > Xiangfu > > On Sat, Oct 13, 2012 at 11:01 AM, Marek Vasut wrote: > > Dear xiangfu at openmobilefree.net, > > > > > From: Xiangfu > > > > > > JZ4740 CPU have a internal ROM have such kind of code, that make > > > JZ4740 can boot from USB > > > > > > usbboot.S can downloads user program from the USB port to internal > > > SRAM and branches to the internal SRAM to execute the program > > > > > > Signed-off-by: Xiangfu > > > --- > > > > > > board/qi/qi_lb60/qi_lb60-spl.c | 20 + > > > board/qi/qi_lb60/usbboot.S | 838 > > > > > > ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 858 > > > insertions(+) > > > > > > create mode 100644 board/qi/qi_lb60/usbboot.S > > > > [...] > > > > UGH. Simply ... UGH. > > > > Can that assembler blob not be rewritten into C ? > > > > Best regards, > > Marek Vasut Best regards, Marek Vasut