From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 2/2] qi_lb60: add software usbboot support
Date: Sat, 13 Oct 2012 14:52:17 +0200 [thread overview]
Message-ID: <201210131452.17568.marex@denx.de> (raw)
In-Reply-To: <CAFJCZHQrYsc05gwE+5nXJyJcTgXb6y_qBGPczfbXbpUycuu3Fg@mail.gmail.com>
Dear xiangfu liu,
> Hi Marek
>
> On Sat, Oct 13, 2012 at 8:23 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear xiangfu liu,
> >
> > > Hi Marek
> > >
> > > This file was wrote by Ingenic people. I don't have time to convert it
> > > to C(I am not very good in mips assembler). the .S file implement
> > > basic USB stack.
> >
> > We already do have an USB stack.
>
> This usbboot.S implement a very base usb-client protocol and it implement a
> jz4740 hardware feature.
We have that too -- see drivers/usb/gadget/
> (jz4740 have a hard-code rom inside cpu. that have
> the same feature, they named it 'boot from usb'). so this usbboot.S is for
> implement the same feature in a software way.
Won't DFU work then?
> and I think this usbboot.S
> can move to 'arch/mips/cpu/xburst/spl/jz4740_usbboot.s' in future. and I
> don't think
> it will impact with other usb code in u-boot.
That's even worse, the USB code shall be in drivers/usb/
> > > this C code (
> >
> > http://projects.qi-hardware.com/index.php/p/xburst-tools/source/tree/mast
> > er
> >
> > > /xbboot) implement the host app. the host app source code even clear
> > > then the original Ingenic document. so feel free to send patch.
> >
> > Sorry, but it is my duty as a USB custodian to NAK patches which try to
> > circumvent the constant effort to keep the code clean. Obviously,
> > implementing
> > yet another USB stack is violation of this.
>
> Yes. I understand your duty. and keep a project code clean is not easy.
> thanks for
> feedback. (I never look into u-boot usb code. don't have much experience on
> u-boot
> usb structure. :)
>
> All the best
> Xiangfu
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-10-13 12:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 1:59 [U-Boot] [PATCH v5 0/2] qi_lb60(Ben NanoNote): add nand spl and usbboot support xiangfu at openmobilefree.net
2012-10-12 1:59 ` [U-Boot] [PATCH v5 1/2] qi_lb60: add nand spl support xiangfu at openmobilefree.net
2012-10-12 1:59 ` [U-Boot] [PATCH v5 2/2] qi_lb60: add software usbboot support xiangfu at openmobilefree.net
2012-10-13 3:01 ` Marek Vasut
2012-10-13 12:20 ` xiangfu liu
2012-10-13 12:23 ` Marek Vasut
2012-10-13 12:46 ` xiangfu liu
2012-10-13 12:52 ` Marek Vasut [this message]
2012-10-13 13:11 ` Xiangfu Liu
2012-10-13 2:59 ` [U-Boot] [PATCH v5 1/2] qi_lb60: add nand spl support Marek Vasut
2012-10-13 12:24 ` Xiangfu Liu
2012-10-13 12:50 ` Marek Vasut
2012-10-13 13:12 ` Xiangfu Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210131452.17568.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox