From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 14 Oct 2012 01:45:06 +0200 Subject: [U-Boot] [PATCH v3 2/5] arm bootm: Do not append zero ATAG_MEM In-Reply-To: <1350156720-13387-3-git-send-email-pali.rohar@gmail.com> References: <1327415291-13260-1-git-send-email-pali.rohar@gmail.com> <1350156720-13387-1-git-send-email-pali.rohar@gmail.com> <1350156720-13387-3-git-send-email-pali.rohar@gmail.com> Message-ID: <201210140145.06730.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Pali Roh?r, > If dram bank size is calculated at runtime, it can be zero on some boards. > This patch added code which ignore these zero bank size in ATAG_MEM. > > Signed-off-by: Pali Roh?r > --- > arch/arm/lib/bootm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c > index c092bfa..925925d 100644 > --- a/arch/arm/lib/bootm.c > +++ b/arch/arm/lib/bootm.c > @@ -132,6 +132,9 @@ static void setup_memory_tags(bd_t *bd) > int i; > > for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) { > + if (bd->bi_dram[i].size == 0) > + continue; This doesn't look right at all, your board is misconfigured if bd->bi_dram[i] == 0. Did you misconfigure CONFIG_NR_DRAM_BANKS ? > params->hdr.tag = ATAG_MEM; > params->hdr.size = tag_size (tag_mem32); Best regards, Marek Vasut