[U-Boot] [PATCH V2 04/21] imximage: cleanup parsing

Stefano Babic
2012-09-23T11:08:39Z

On 22/09/2012 04:39, Troy Kisky wrote:
> Move to pulling tokens instead of pushing them.
> Remove need for switch statements to process commands.
> Add error messages such as "command not finished",
> "extra data at end of line", and "invalid token"
> Add ';' as command separator.
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> ---

Hi Troy,

you add code in previous patch and you remove it in this one. This makes
quite difficult to review them.

Normally, we do do have this case, and code is not added and removed in
the same patches series. Should you not squash patches together and / or
rearrange them with different topic ?

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================