[U-Boot] [PATCH V3 00/32] Add mx6solo/mx6duallite support

Eric Nelson
2012-10-04T14:52:25Z

Hi Troy,

On 10/03/2012 06:47 PM, Troy Kisky wrote:
> This series goal is to add support for mx6solo and mx6duallite
> variants of mx6qsabrelite board. The new targets are
> called mx6ssabrelite and mx6dlsabrelite.
>
> The 1st 16 patches perform cleanup on imximage
>
> The final 2 patches add support for expressions to mkimage.
> If found not to be worth the effort, they can be omitted.
>
>
> Troy Kisky (32):
> imximage: check dcd_len as entries added
> imximage: remove redundant setting of app_dest_ptr
> imximage: move flash_offset check to common location
> imximage: fix size of image to load.
> imximage: delay setting of image size
> imximage: change parameters to set_imx_hdr
> imximage: make set_imx_hdr_v1/v2 easier to read
> imximage: make header variable length
> imximage: remove static imximage_version
> imximage: prepare to move static variables to struct data_src
> imximage: change parameters for set_dcd_val/set_imx_hdr
> imximage: move set_imx_hdr to struct data_src
> imximage: move set_dcd_val to struct data_src
> imximage: enable word writes for version2 header
> tools: add parse_helper file
> imximage: use parse_helper functions
> imximage.cfg: run files through C preprocessor
> mx6q_4x_mt41j128.cfg: use symbols instead of hardcoded constants
> mx6q_4x_mt41j128.cfg: add comments
> mx6q_4x_mt41j128.cfg: use ddr3 mode for reset
> mx6q_4x_mt41j128.cfg: skip initiailizing non-existent memory
> mx6q_4x_mt41j128.cfg: force ZQ calibration
> mx6: soc: update get_cpu_rev and get_imx_type for mx6solo/sololite
> mx6: use CONFIG_MX6 instead of CONFIG_MX6Q
> imx-common: cpu: add imx_ddr_size
> arch-mx6: add mx6dl_pins.h
> mx6qsabrelite: add support for mx6 solo/duallite
> mx6q_4x_mt41j128.cfg: add mx6 solo/duallite support
> Add boards for sabrelite variants mx6s(solo) and mx6dl(duallite)
> mx6qsabrelite: change CONFIG_SYS_PROMPT
> parse_helper: add expression evaluation
> imx-mkimage.h: use base + offset syntax
>
> Makefile | 3 +-
> arch/arm/cpu/armv7/mx6/soc.c | 32 +-
> arch/arm/imx-common/cpu.c | 66 +++-
> arch/arm/include/asm/arch-mx5/sys_proto.h | 10 +-
> arch/arm/include/asm/arch-mx6/imx-mkimage.h | 133 +++++++
> arch/arm/include/asm/arch-mx6/imx-regs.h | 2 +
> arch/arm/include/asm/arch-mx6/mx6dl_pins.h | 118 ++++++
> arch/arm/include/asm/arch-mx6/sys_proto.h | 10 +-
> board/esg/ima3-mx53/imximage.cfg | 120 +++---
> board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg | 425 ++++++++++++---------
> board/freescale/mx25pdk/imximage.cfg | 77 ++--
> board/freescale/mx51evk/imximage.cfg | 114 +++---
> board/freescale/mx53ard/imximage_dd3.cfg | 83 +++--
> board/freescale/mx53evk/imximage.cfg | 86 ++---
> board/freescale/mx53loco/imximage.cfg | 83 +++--
> board/freescale/mx53smd/imximage.cfg | 83 +++--
> board/freescale/mx6qarm2/imximage.cfg | 88 ++---
> board/freescale/mx6qsabrelite/mx6qsabrelite.c | 235 +++---------
> board/freescale/mx6qsabrelite/pads.h | 172 +++++++++
> board/genesi/mx51_efikamx/imximage_mx.cfg | 132 +++----
> board/genesi/mx51_efikamx/imximage_sb.cfg | 126 ++++---
> board/ttcontrol/vision2/imximage_hynix.cfg | 295 ++++++++-------
> boards.cfg | 4 +-
> drivers/gpio/mxc_gpio.c | 6 +-
> drivers/video/ipu_regs.h | 2 +-
> include/configs/mx6qarm2.h | 1 +
> include/configs/mx6qsabre_common.h | 1 +
> include/configs/mx6qsabrelite.h | 4 +-
> tools/Makefile | 2 +
> tools/imximage.c | 487 ++++++++++---------------
> tools/imximage.h | 39 +-
> tools/parse_helper.c | 325 +++++++++++++++++
> tools/parse_helper.h | 28 ++
> 33 files changed, 2106 insertions(+), 1286 deletions(-)
> create mode 100644 arch/arm/include/asm/arch-mx6/imx-mkimage.h
> create mode 100644 arch/arm/include/asm/arch-mx6/mx6dl_pins.h
> create mode 100644 board/freescale/mx6qsabrelite/pads.h
> create mode 100644 tools/parse_helper.c
> create mode 100644 tools/parse_helper.h
>

There's clearly a lot going on in this patch set. Does it make
sense to split this into parts that can be reviewed and checked
separately?

It seems that there are
- bug fixes to imximage
- enhancements to imximage
- enhancements to build for imximage.cfg (CPP)
- core i.MX6 changes (cpu types, etc)
- rework of imximage.cfg files to use CPP
...

And there's that simple one changing the prompt we can
probably get a quick ack/nak on ;)