From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6 V3] common: Add symbol handling for generic lists into Makefile
Date: Mon, 15 Oct 2012 04:09:23 +0200 [thread overview]
Message-ID: <201210150409.23619.marex@denx.de> (raw)
In-Reply-To: <CACUy__XUsjszn__D+otjaeQgwKVWErVgwudWJWJ-r080eTTPPA@mail.gmail.com>
Dear Daniel Schwierzeck,
> 2012/10/15 Marek Vasut <marex@denx.de>:
> >> > GEN_UBOOT = \
> >> >
> >> > UNDEF_SYM=`$(OBJDUMP) -x $(LIBBOARD) $(LIBS) | \
> >> > sed -n -e
> >> > 's/.*\($(SYM_PREFIX)__u_boot_cmd_.*\)/-u\1/p'|sort|uni
> >> > q` ;\
> >> >
> >> > - cd $(LNDIR) && $(LD) $(LDFLAGS) $(LDFLAGS_$(@F))
> >> > $$UNDEF_SYM $(__OBJS) \ + UNDEF_LST=`$(OBJDUMP) -x
> >> > $(LIBBOARD) $(LIBS) | \ + sed -n -e
> >> > 's/.*\($(SYM_PREFIX)__u_boot_list_.*\)/-u\1/p'|sort|uniq`;\
> >>
> >> this must be:
> >> > + sed -n -e
> >> > 's/.*\($(SYM_PREFIX)_u_boot_list_.*\)/-u\1/p'|sort|uniq`;\
> >
> > I suspect this might break blackfin.
>
> no it is already broken without this change. I also tested Blackfin
> but forgot it to mention.
> Blackfin explicitely sets SYM_PREFIX:=_ so you will finally get
> __u_boot_list_.*.
Which is what I _want_ to get.
> >> otherwise $UNDEF_LST is always empty which breaks at least all MIPS
> >> boards because
> >> all _uboot_list_* symbols are discarded by the linker. I noticed that
> >> on ARM and PowerPC
> >> the content of $UNDEF_LST does not matter at all because those symbols
> >> are always linked into the final binary.
> >
> > About time to fix mips ... or throw it away altogether, until it learns
> > to do stuff right (incl. relocation).
>
> it's not only MIPS, Blackfin has the same problem. Propably other
> 'exotic' archs too ;)
And that's a problem -- we have to support so much legacy crap because of these
arches :-(
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-10-15 2:09 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 0:17 [U-Boot] [PATCH 0/5] Linker-generated arrays (take 2) Marek Vasut
2012-09-30 0:17 ` [U-Boot] [PATCH 1/5] common: Add symbol handling for generic lists into Makefile Marek Vasut
2012-10-02 23:40 ` Joe Hershberger
2012-09-30 0:17 ` [U-Boot] [PATCH 2/5] common: Implement support for linker-generated arrays Marek Vasut
2012-10-02 23:40 ` Joe Hershberger
2012-09-30 0:17 ` [U-Boot] [PATCH 3/5] common: Add .u_boot_list into all linker files Marek Vasut
2012-10-02 23:41 ` Joe Hershberger
2012-10-03 14:55 ` Daniel Schwierzeck
2012-10-03 15:01 ` Marek Vasut
2012-10-03 15:21 ` Daniel Schwierzeck
2012-10-03 16:44 ` Marek Vasut
2012-10-03 18:05 ` Daniel Schwierzeck
2012-10-03 20:49 ` [U-Boot] [PATCH 3/5 V2] " Marek Vasut
2012-09-30 0:17 ` [U-Boot] [PATCH 4/5] common: Convert the U-Boot commands to LG-arrays Marek Vasut
2012-10-02 23:43 ` Joe Hershberger
2012-09-30 0:17 ` [U-Boot] [PATCH 5/5] common: Discard the __u_boot_cmd section Marek Vasut
2012-10-02 23:43 ` Joe Hershberger
2012-10-03 14:56 ` Daniel Schwierzeck
2012-10-03 20:50 ` [U-Boot] [PATCH 5/5 V2] " Marek Vasut
2012-10-07 0:06 ` [U-Boot] [PATCH 0/6 V2] Linker-generated arrays (take 2) Marek Vasut
2012-10-07 0:06 ` [U-Boot] [PATCH 1/6 V2] common: Add symbol handling for generic lists into Makefile Marek Vasut
2012-10-07 0:06 ` [U-Boot] [PATCH 2/6 V2] common: Implement support for linker-generated arrays Marek Vasut
2012-10-07 0:06 ` [U-Boot] [PATCH 3/6 V2] common: Add .u_boot_list into all linker files Marek Vasut
2012-10-07 0:06 ` [U-Boot] [PATCH 4/6 V2] common: Convert the U-Boot commands to LG-arrays Marek Vasut
2012-10-07 0:06 ` [U-Boot] [PATCH 5/6 V2] common: Discard the __u_boot_cmd section Marek Vasut
2012-10-07 0:06 ` [U-Boot] [PATCH 6/6 V2] kerneldoc: tmpl: Implement template for LG-arrays Marek Vasut
2012-10-12 20:27 ` [U-Boot] [PATCH 0/6 V3] Linker-generated arrays (take 2) Marek Vasut
2012-10-12 20:27 ` [U-Boot] [PATCH 1/6 V3] common: Add symbol handling for generic lists into Makefile Marek Vasut
2012-10-14 23:28 ` Daniel Schwierzeck
2012-10-15 1:49 ` Marek Vasut
2012-10-15 2:04 ` Daniel Schwierzeck
2012-10-15 2:09 ` Marek Vasut [this message]
2012-10-17 10:43 ` [U-Boot] [PATCH 1/6 V4] " Marek Vasut
2012-10-18 19:40 ` Wolfgang Denk
2012-10-19 13:19 ` Marek Vasut
2012-10-20 17:46 ` Tom Rini
2012-10-20 18:56 ` Marek Vasut
2012-10-21 5:20 ` Tom Rini
2012-10-19 15:00 ` [U-Boot] [PATCH 1/6 V5] " Marek Vasut
2012-10-19 15:45 ` Joe Hershberger
2012-10-19 15:48 ` Joe Hershberger
2012-10-22 21:04 ` Tom Rini
2012-10-12 20:27 ` [U-Boot] [PATCH 2/6 V3] common: Implement support for linker-generated arrays Marek Vasut
2012-10-12 20:27 ` [U-Boot] [PATCH 3/6 V3] common: Add .u_boot_list into all linker files Marek Vasut
2012-10-12 20:27 ` [U-Boot] [PATCH 4/6 V3] common: Convert the U-Boot commands to LG-arrays Marek Vasut
2012-10-12 20:27 ` [U-Boot] [PATCH 5/6 V3] common: Discard the __u_boot_cmd section Marek Vasut
2012-10-17 10:45 ` [U-Boot] [PATCH 5/6 V4] " Marek Vasut
2012-10-12 20:27 ` [U-Boot] [PATCH 6/6 V3] kerneldoc: tmpl: Implement template for LG-arrays Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210150409.23619.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox